From c39f0097393f5427b45657ecb3858a1b9ae529f7 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Thu, 21 Jan 2021 13:42:17 -0700 Subject: [PATCH] soc/amd/picasso/acpi: Add UID for PCI INT devices If a _HID/_CID are not unique, we need to add a _UID field to differentiate the objects. BUG=b:175146875 BRANCH=zork TEST=Boot linux, dump ACPI table and verify UIDs are unique Signed-off-by: Raul E Rangel Change-Id: Icd2ccede2b6c2e332157e2eeca89fba14a46b360 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49811 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/soc/amd/picasso/acpi/pci_int.asl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl index feaec12d29..0a6dec8906 100644 --- a/src/soc/amd/picasso/acpi/pci_int.asl +++ b/src/soc/amd/picasso/acpi/pci_int.asl @@ -20,10 +20,10 @@ } }) -#define PCI_LINK(DEV_NAME, PIC_REG, APIC_REG) \ +#define PCI_LINK(DEV_NAME, PIC_REG, APIC_REG, UID) \ Device(DEV_NAME) { \ Name(_HID, EISAID("PNP0C0F")) \ - Name(_UID, 1) \ + Name(_UID, UID) \ \ Method(_STA, 0) { \ If (PMOD) { \ @@ -100,11 +100,11 @@ } \ } -PCI_LINK(INTA, PIRA, IORA) -PCI_LINK(INTB, PIRB, IORB) -PCI_LINK(INTC, PIRC, IORC) -PCI_LINK(INTD, PIRD, IORD) -PCI_LINK(INTE, PIRE, IORE) -PCI_LINK(INTF, PIRF, IORF) -PCI_LINK(INTG, PIRG, IORG) -PCI_LINK(INTH, PIRH, IORH) +PCI_LINK(INTA, PIRA, IORA, 0) +PCI_LINK(INTB, PIRB, IORB, 1) +PCI_LINK(INTC, PIRC, IORC, 2) +PCI_LINK(INTD, PIRD, IORD, 3) +PCI_LINK(INTE, PIRE, IORE, 4) +PCI_LINK(INTF, PIRF, IORF, 5) +PCI_LINK(INTG, PIRG, IORG, 6) +PCI_LINK(INTH, PIRH, IORH, 7)