GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/smsc/lpc47m10x: Use link-time symbols over .c inclusion 

Change-Id: I4a3639c05231eacd016ec3873330f9844befd448
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8080
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan 2015-01-04 16:24:14 +11:00
parent 536a44390d
commit c3e77fc953
4 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/aopen/dxplplusu/romstage.c
View File

@ -29,8 +29,7 @@
#include "northbridge/intel/e7505/raminit.h" #include "northbridge/intel/e7505/raminit.h"
#include <device/pnp_def.h> #include <device/pnp_def.h>
#include "superio/smsc/lpc47m10x/early_serial.c" #include <superio/smsc/lpc47m10x/lpc47m10x.h>
#define SERIAL_DEV PNP_DEV(0x2e, LPC47M10X2_SP1) #define SERIAL_DEV PNP_DEV(0x2e, LPC47M10X2_SP1)

1
src/superio/smsc/lpc47m10x/Makefile.inc
View File

@ -22,4 +22,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_SMSC_LPC47M10X) += early_serial.c
ramstage-$(CONFIG_SUPERIO_SMSC_LPC47M10X) += superio.c ramstage-$(CONFIG_SUPERIO_SMSC_LPC47M10X) += superio.c

4
src/superio/smsc/lpc47m10x/early_serial.c
View File

@ -19,6 +19,8 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include <stdint.h>
#include "lpc47m10x.h" #include "lpc47m10x.h"
static void pnp_enter_conf_state(pnp_devfn_t dev) static void pnp_enter_conf_state(pnp_devfn_t dev)
@ -40,7 +42,7 @@ static void pnp_exit_conf_state(pnp_devfn_t dev)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number. * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param iobase Processor I/O port address to assign to this serial device. * @param iobase Processor I/O port address to assign to this serial device.
*/ */
static void lpc47m10x_enable_serial(pnp_devfn_t dev, u16 iobase) void lpc47m10x_enable_serial(pnp_devfn_t dev, u16 iobase)
{ {
pnp_enter_conf_state(dev); pnp_enter_conf_state(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

11
src/superio/smsc/lpc47m10x/lpc47m10x.h
View File

@ -20,8 +20,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_SMSC_LPC47M10X_LPC47M10X_H #ifndef SUPERIO_SMSC_LPC47M10X_H
#define SUPERIO_SMSC_LPC47M10X_LPC47M10X_H #define SUPERIO_SMSC_LPC47M10X_H
#define LPC47M10X2_FDC 0 /* Floppy */ #define LPC47M10X2_FDC 0 /* Floppy */
#define LPC47M10X2_PP 3 /* Parallel Port */ #define LPC47M10X2_PP 3 /* Parallel Port */
@ -34,4 +34,9 @@
#define LPC47M10X2_MAX_CONFIG_REGISTER 0x5F #define LPC47M10X2_MAX_CONFIG_REGISTER 0x5F
#endif #include <arch/io.h>
#include <stdint.h>
void lpc47m10x_enable_serial(pnp_devfn_t dev, u16 iobase);
#endif /* SUPERIO_SMSC_LPC47M10X_H */