From c4062c78a9d353d8d1f5250ab9bf65dda28c2b0c Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Thu, 11 Feb 2021 10:43:14 +0100 Subject: [PATCH] device: Add unit to Kconfig option name: `PRE_GRAPHICS_DELAY_MS` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s good practice to put the unit into the name. Change-Id: I1493f61d4e495c22f09abf1829bb2eab9b1fd2b6 Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/c/coreboot/+/50517 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Nico Huber --- Documentation/getting_started/kconfig.md | 2 +- src/device/Kconfig | 2 +- src/device/pci_device.c | 4 ++-- src/mainboard/purism/librem_bdw/Kconfig | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md index 037371bd34..dcc11b4046 100644 --- a/Documentation/getting_started/kconfig.md +++ b/Documentation/getting_started/kconfig.md @@ -607,7 +607,7 @@ int <expr> \[if <expr>\] ##### Example: - config PRE_GRAPHICS_DELAY + config PRE_GRAPHICS_DELAY_MS int "Graphics initialization delay in ms" default 0 help diff --git a/src/device/Kconfig b/src/device/Kconfig index 421ad66fea..8dc9ecdff9 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -117,7 +117,7 @@ config NO_GFX_INIT endchoice -config PRE_GRAPHICS_DELAY +config PRE_GRAPHICS_DELAY_MS int "Graphics initialization delay in ms" default 0 depends on VGA_ROM_RUN diff --git a/src/device/pci_device.c b/src/device/pci_device.c index cd98f07605..161715fadd 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -734,8 +734,8 @@ static int should_load_oprom(struct device *dev) static void oprom_pre_graphics_stall(void) { - if (CONFIG_PRE_GRAPHICS_DELAY) - mdelay(CONFIG_PRE_GRAPHICS_DELAY); + if (CONFIG_PRE_GRAPHICS_DELAY_MS) + mdelay(CONFIG_PRE_GRAPHICS_DELAY_MS); } /** Default handler: only runs the relevant PCI BIOS. */ diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index ad764b7fd6..50c6d5be6a 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -52,7 +52,7 @@ config MAINBOARD_VERSION default "1.0" if BOARD_PURISM_LIBREM13_V1 default "2.0" if BOARD_PURISM_LIBREM15_V2 -config PRE_GRAPHICS_DELAY +config PRE_GRAPHICS_DELAY_MS int default 50