From c44249d52caedfa0cc831ad9670a74e2eb19d621 Mon Sep 17 00:00:00 2001 From: Jon Murphy Date: Fri, 20 May 2022 14:08:27 -0600 Subject: [PATCH] mb/google/guybrush: Remove unused sleep GPIO table On Guybrush, there wasn't a need for a sleep GPIO table. Remove the TODO and filler table and function to reduce unnecessary function calls/overhead. BUG=b:232952508 TEST=Builds Signed-off-by: Jon Murphy Change-Id: Ic51ee4845d663acf34f050f7b3abf57a7c247c88 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64556 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/mainboard/google/guybrush/smihandler.c | 6 ------ .../google/guybrush/variants/baseboard/gpio.c | 11 ----------- 2 files changed, 17 deletions(-) diff --git a/src/mainboard/google/guybrush/smihandler.c b/src/mainboard/google/guybrush/smihandler.c index 1adc1a202a..edabdbd169 100644 --- a/src/mainboard/google/guybrush/smihandler.c +++ b/src/mainboard/google/guybrush/smihandler.c @@ -16,13 +16,7 @@ void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_sleep(u8 slp_typ) { - size_t num_gpios; - const struct soc_amd_gpio *gpios; - chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); - - gpios = variant_sleep_gpio_table(&num_gpios); - gpio_configure_pads(gpios, num_gpios); } int mainboard_smi_apmc(u8 apmc) diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index 53ff85b455..cfbabc1100 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -267,11 +267,6 @@ static const struct soc_amd_gpio bootblock_gpio_table[] = { PAD_GPO(GPIO_130, LOW), }; -/* GPIO configuration for sleep */ -static const struct soc_amd_gpio sleep_gpio_table[] = { - /* TODO: Fill sleep gpio configuration */ -}; - /* PCIE_RST needs to be brought high before FSP-M runs */ static const struct soc_amd_gpio pcie_gpio_table[] = { /* Deassert all AUX_RESET lines & PCIE_RST */ @@ -339,12 +334,6 @@ const struct soc_amd_gpio *__weak variant_early_gpio_table(size_t *size) return early_gpio_table; } -const __weak struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size) -{ - *size = ARRAY_SIZE(sleep_gpio_table); - return sleep_gpio_table; -} - const __weak struct soc_amd_gpio *variant_espi_gpio_table(size_t *size) { *size = ARRAY_SIZE(espi_gpio_table);