GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/taeko{4es}: Remove extraneous __weak attributes 

Functions that are intended to override weak ones defined in the
baseboard should not also be declared weak, otherwise how would
the linker know which copy to keep.

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: Ia2ceee77d00a5baa915fd1f306d76e79aa609e65
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63179
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Tim Wawrzynczak 2022-03-28 13:25:16 -06:00 committed by Felix Held
parent 8e4eb83980
commit c48ec7b2bf
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/brya/variants/taeko/memory.c
View File

@ -66,12 +66,12 @@ static const struct mb_cfg baseboard_memcfg = {
.ect = 1, /* Enable Early Command Training */ .ect = 1, /* Enable Early Command Training */
}; };
const struct mb_cfg *__weak variant_memory_params(void) const struct mb_cfg *variant_memory_params(void)
{ {
return &baseboard_memcfg; return &baseboard_memcfg;
} }
int __weak variant_memory_sku(void) int variant_memory_sku(void)
{ {
/* /*
* Memory configuration board straps * Memory configuration board straps
@ -90,7 +90,7 @@ int __weak variant_memory_sku(void)
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));
} }
bool __weak variant_is_half_populated(void) bool variant_is_half_populated(void)
{ {
/* GPIO_MEM_CH_SEL GPP_E13 */ /* GPIO_MEM_CH_SEL GPP_E13 */
return gpio_get(GPP_E13); return gpio_get(GPP_E13);

6
src/mainboard/google/brya/variants/taeko4es/memory.c
View File

@ -66,12 +66,12 @@ static const struct mb_cfg baseboard_memcfg = {
.ect = 1, /* Enable Early Command Training */ .ect = 1, /* Enable Early Command Training */
}; };
const struct mb_cfg *__weak variant_memory_params(void) const struct mb_cfg *variant_memory_params(void)
{ {
return &baseboard_memcfg; return &baseboard_memcfg;
} }
int __weak variant_memory_sku(void) int variant_memory_sku(void)
{ {
/* /*
* Memory configuration board straps * Memory configuration board straps
@ -90,7 +90,7 @@ int __weak variant_memory_sku(void)
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));
} }
bool __weak variant_is_half_populated(void) bool variant_is_half_populated(void)
{ {
/* GPIO_MEM_CH_SEL GPP_E13 */ /* GPIO_MEM_CH_SEL GPP_E13 */
return gpio_get(GPP_E13); return gpio_get(GPP_E13);