GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/smi_trigger: call pm_acpi_smi_cmd_port to get APMC SMI IO port 

Instead of hard-coding the APMC SMI command IO port in the FADT, call
pm_acpi_smi_cmd_port() to get the APMC SMI command IO port. Also update
the comment in apm_get_apmc to match what it's doing.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I0f36b8a0e93a82b8c6d23c5c5d8fbebb1bc6b0bc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79567
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
This commit is contained in:
Felix Held 2023-12-14 20:59:54 +01:00
parent 8fdf183175
commit c4fbc9146d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cpu/x86/smi_trigger.c
View File

@ -38,7 +38,7 @@ int apm_control(u8 cmd)
apmc_log(__func__, cmd);
/* Now raise the SMI. */
outb(cmd, APM_CNT);
outb(cmd, pm_acpi_smi_cmd_port());
printk(BIOS_DEBUG, "APMC done.\n");
return 0;
@ -46,8 +46,8 @@ int apm_control(u8 cmd)
u8 apm_get_apmc(void)
{
/* Emulate B2 register as the FADT / Linux expects it */
u8 cmd = inb(APM_CNT);
/* Read command byte from APMC SMI IO port */
u8 cmd = inb(pm_acpi_smi_cmd_port());
apmc_log("SMI#", cmd);
return cmd;