GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/amdfwtool: remove unused union from embedded_firmware struct 

Since commit 2f6b7d557d ("amdfwtool: Move the filling of table headers
into functions"), the combo_psp_directory union element in the
embedded_firmware is unused and the new_psp_directory element is used in
all places, so replace the union of new_psp_directory and
combo_psp_directory with just the new_psp_directory struct element.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I35d339b3084ec8f93210095c233f5e68296d0013
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73834
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Felix Held 2023-03-20 16:02:47 +01:00
parent 0f0b619953
commit c5c7fa494b
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
util/amdfwtool/amdfwtool.h
View File

@ -148,10 +148,7 @@ typedef struct _embedded_firmware {
uint32_t gec_entry; uint32_t gec_entry;
uint32_t xhci_entry; uint32_t xhci_entry;
uint32_t psp_directory; uint32_t psp_directory;
union { uint32_t new_psp_directory; /* also used as combo_psp_directory */
uint32_t new_psp_directory;
uint32_t combo_psp_directory;
};
uint32_t bios0_entry; /* todo: add way to select correct entry */ uint32_t bios0_entry; /* todo: add way to select correct entry */
uint32_t bios1_entry; uint32_t bios1_entry;
uint32_t bios2_entry; uint32_t bios2_entry;