GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

selfboot: fix bug in valid_area() 

valid_area will accept a region as valid for the payload if only a part
of coreboot fits in that region. This means if a payload reaches into a
neighboring RESERVED region, coreboot would not care and happily
overwrite that region, as long as the payload also writes to some RAM.

Change-Id: Ie263f83be18009b01a31c71e7285c998747d097f
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/425
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Stefan Reinauer 2011-11-07 12:56:12 -08:00 committed by Patrick Georgi
parent 2e2b84e420
commit c6b8b7dcc4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/boot/selfboot.c
View File

@ -140,10 +140,10 @@ static int valid_area(struct lb_memory *mem, unsigned long buffer,
mtype = mem->map[i].type; mtype = mem->map[i].type;
mstart = unpack_lb64(mem->map[i].start); mstart = unpack_lb64(mem->map[i].start);
mend = mstart + unpack_lb64(mem->map[i].size); mend = mstart + unpack_lb64(mem->map[i].size);
if ((mtype == LB_MEM_RAM) && (start < mend) && (end > mstart)) { if ((mtype == LB_MEM_RAM) && (start >= mstart) && (end < mend)) {
break; break;
} }
if ((mtype == LB_MEM_TABLE) && (start < mend) && (end > mstart)) { if ((mtype == LB_MEM_TABLE) && (start >= mstart) && (end < mend)) {
printk(BIOS_ERR, "Payload is overwriting coreboot tables.\n"); printk(BIOS_ERR, "Payload is overwriting coreboot tables.\n");
break; break;
} }