GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/x4x: Don't use PCI operations on the pci_domain device 

pci ops happen to work on this struct device since the device_path is an union.

This patch still keeps adding the fixed resources in the pci_domain
ops since moving it to the PCI ops which could properly use the
function argument for PCI operations would require all PCI IDs to be
added or else breakages are to be expected.

Change-Id: Iabfd15884ec8feb846d01b6af3c4afe5c1494feb
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/27245
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2018-06-26 21:06:38 +02:00 committed by Felix Held
parent 17041207f2
commit c6e13b6690
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/northbridge/intel/x4x/northbridge.c
View File

@ -44,16 +44,18 @@ static void mch_domain_read_resources(struct device *dev)
pci_domain_read_resources(dev); pci_domain_read_resources(dev);
struct device *mch = dev_find_slot(0, PCI_DEVFN(0, 0));
/* Top of Upper Usable DRAM, including remap */ /* Top of Upper Usable DRAM, including remap */
touud = pci_read_config16(dev, D0F0_TOUUD); touud = pci_read_config16(mch, D0F0_TOUUD);
touud <<= 20; touud <<= 20;
/* Top of Lower Usable DRAM */ /* Top of Lower Usable DRAM */
tolud = pci_read_config16(dev, D0F0_TOLUD) & 0xfff0; tolud = pci_read_config16(mch, D0F0_TOLUD) & 0xfff0;
tolud <<= 16; tolud <<= 16;
/* Top of Memory - does not account for any UMA */ /* Top of Memory - does not account for any UMA */
tom = pci_read_config16(dev, D0F0_TOM) & 0x01ff; tom = pci_read_config16(mch, D0F0_TOM) & 0x01ff;
tom <<= 26; tom <<= 26;
printk(BIOS_DEBUG, "TOUUD 0x%llx TOLUD 0x%08x TOM 0x%llx\n", printk(BIOS_DEBUG, "TOUUD 0x%llx TOLUD 0x%08x TOM 0x%llx\n",
@ -63,7 +65,7 @@ static void mch_domain_read_resources(struct device *dev)
/* Graphics memory comes next */ /* Graphics memory comes next */
const u16 ggc = pci_read_config16(dev, D0F0_GGC); const u16 ggc = pci_read_config16(mch, D0F0_GGC);
printk(BIOS_DEBUG, "IGD decoded, subtracting "); printk(BIOS_DEBUG, "IGD decoded, subtracting ");
/* Graphics memory */ /* Graphics memory */
@ -79,7 +81,7 @@ static void mch_domain_read_resources(struct device *dev)
uma_sizek += gsm_sizek; uma_sizek += gsm_sizek;
printk(BIOS_DEBUG, "TSEG decoded, subtracting "); printk(BIOS_DEBUG, "TSEG decoded, subtracting ");
reg8 = pci_read_config8(dev, D0F0_ESMRAMC); reg8 = pci_read_config8(mch, D0F0_ESMRAMC);
reg8 >>= 1; reg8 >>= 1;
reg8 &= 3; reg8 &= 3;
switch (reg8) { switch (reg8) {