GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

google/parrot: Fix keyboard interrupts, DSDT

Browse source 
Commit 967cd9a [ChromeOS: fix Kconfig dependencies] broke keyboard
interrupts on parrot by making SERIRQ_CONTINUOUS_MODE conditional on
CONFIG_CHROMEOS, which it should not be; fix by moving back under main
board specific options config.

Additionally, Windows [8/8.1/10] fails to enumerate the keyboard when
its ACPI entry is located under the SIO device since it is missing an
_HID entry, so add the appropriate value per ACPI spec 5 ch. 9.7

Change-Id: Ia69e9b326001d2026b15b4ec03c94f7d03c8a700
Signed-off-by: Prabal Saha <coolstarorganization@gmail.com>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/17017
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Prabal Saha 2016-10-13 07:52:23 -07:00 committed by Nico Huber
parent bf618cb94e
commit c7098a61b1
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/ec/compal/ene932/acpi/superio.asl
View file

@ -16,6 +16,7 @@
// Scope is \_SB.PCI0.LPCB // Scope is \_SB.PCI0.LPCB
Device (SIO) { Device (SIO) {
Name (_HID, EisaId("PNP0A05"))
Name (_UID, 0) Name (_UID, 0)
Name (_ADR, 0) Name (_ADR, 0)

5
src/mainboard/google/parrot/Kconfig
View file

@ -14,13 +14,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM
select INTEL_INT15 select INTEL_INT15
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
config CHROMEOS config CHROMEOS
select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS
# Workaround for EC/KBC IRQ1.
select SERIRQ_CONTINUOUS_MODE
config MAINBOARD_DIR config MAINBOARD_DIR
string string
default google/parrot default google/parrot