From c75c8c15b99b5045caa77b2447cfff69b725576c Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 13 Jul 2021 02:00:55 +0200 Subject: [PATCH] soc/intel/common/block/cpu/cpulib: use mca_get_bank_count() Use the common mca_get_bank_count function instead of open-coding the functionality to get the MCA bank number. Also re-type the num_banks variable from signed in to unsigned int, since the number of MCA bank is always positive, and make it constant. Change-Id: I449c74629ff16057c4559d7fd3620208230560f5 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/56245 Reviewed-by: Raul Rangel Reviewed-by: Patrick Rudolph Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/cpu/cpulib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index 9e95b0f9f4..a245824821 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -338,12 +338,10 @@ void mca_configure(void) { msr_t msr; int i; - int num_banks; + const unsigned int num_banks = mca_get_bank_count(); printk(BIOS_DEBUG, "Clearing out pending MCEs\n"); - msr = rdmsr(IA32_MCG_CAP); - num_banks = msr.lo & 0xff; msr.lo = msr.hi = 0; for (i = 0; i < num_banks; i++) {