GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/acpi: Remove EC PTS/WAK dynamic loading 

Use CondRefOf to replace config optios for PTS/WAK acpi method dynamic
loading. Then we can move EC PTS and WAK method to be under mainboard.

BUG=N/A
TEST=Build sarien source code, check build/dsdt.dsl have EC.PTS method
included, build whlrvp soure, check build/dsdt.dsl don't have EC.PTS
method. Both able to build pass.

Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Change-Id: I9f4bd7240832caf070e65039e4ba2d8656371da8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32371
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Lijian Zhao 2019-04-19 20:21:43 -07:00 committed by Duncan Laurie
parent b3ddb29c36
commit c7817bc128
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/sarien/Kconfig
View File

@ -16,7 +16,6 @@ config BOARD_GOOGLE_BASEBOARD_SARIEN
select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_I2C_TPM_CR50
select MAINBOARD_HAS_TPM2
select SOC_INTEL_COMMON_ACPI_EC_PTS_WAK
select SOC_INTEL_WHISKEYLAKE
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_DISABLE

7
src/soc/intel/common/Kconfig
View File

@ -51,13 +51,6 @@ config SOC_INTEL_COMMON_ACPI
bool
default n
config SOC_INTEL_COMMON_ACPI_EC_PTS_WAK
bool
default n
help
Set this option to have the platform level _PTS/_WAK methods call
methods provided by the Embedded Controller.
config SOC_INTEL_COMMON_NHLT
bool
default n

9
src/soc/intel/common/acpi/platform.asl
View File

@ -37,10 +37,6 @@ Method (_PTS, 1)
{
Store (POST_OS_ENTER_PTS, DBG0)
#if CONFIG(SOC_INTEL_COMMON_ACPI_EC_PTS_WAK)
/* Call EC _PTS handler */
\_SB.PCI0.LPCB.EC0.PTS (Arg0)
#endif
If (CondRefOf (\_SB.MPTS))
{
\_SB.MPTS (Arg0)
@ -58,10 +54,5 @@ Method (_WAK, 1)
\_SB.MWAK (Arg0)
}
#if CONFIG(SOC_INTEL_COMMON_ACPI_EC_PTS_WAK)
/* Call EC _WAK handler */
\_SB.PCI0.LPCB.EC0.WAK (Arg0)
#endif
Return (Package(){0,0})
}