GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "nipperkin: Fix WLAN to GEN2 speed" & "Disable PSPP for WLAN" 

Updated Linux FW works with PCI gen3 speed and PSPP.

This reverts
commit 05c9a850fd ("mb/google/nipperkin: Fix WLAN to GEN2 speed")
https://review.coreboot.org/c/coreboot/+/63593

and
commit 76fddd9639 ("mb/google/nipperkin: Disable PSPP for WLAN")
https://review.coreboot.org/c/coreboot/+/63722

The changes are overlapped and are reverted together.

BUG=b:240426142 & b:228830362

The system is able to ran over 2500 cycles on Nipperkin with command
suspend_stress_test -c 10000 --wake_min 10 --suspend_min 10 \
    --nofw_errors_fatal

The whole variant_update_dxio_descriptors is empty and is pushed back
to weak function.

Change-Id: Id207076542edc8ea0cabc6e02e29856c2b6803c7
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79172
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
This commit is contained in:
Zheng Bao 2023-11-20 14:52:43 +08:00 committed by Felix Held
parent 87837df807
commit c7a5c50760
2 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc
View File

@ -9,10 +9,6 @@ romstage-y += tpm_tis.c
ramstage-y += tpm_tis.c ramstage-y += tpm_tis.c
verstage-y += tpm_tis.c verstage-y += tpm_tis.c
bootblock-y += variant.c
romstage-y += variant.c
ramstage-y += variant.c
ramstage-y += ramstage.c ramstage-y += ramstage.c
subdirs-y += ./memory subdirs-y += ./memory

15
src/mainboard/google/guybrush/variants/nipperkin/variant.c
View File

@ -1,15 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h>
void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors)
{
/* Fix link speed to GEN2 - b/228830362 */
dxio_descriptors[WLAN].link_speed_capability = GEN2;
dxio_descriptors[WLAN].port_params[0] = PP_PSPP_AC;
/* AC_DirectIndirect[11:8], AC_MaxPreferredSpeed[7:4], AC_MinPreferredSpeed[3:0] */
dxio_descriptors[WLAN].port_params[1] = 0x122;
dxio_descriptors[WLAN].port_params[2] = PP_PSPP_DC;
/* DC_DirectIndirect[11:8], DC_MaxPreferredSpeed[7:4], DC_MinPreferredSpeed[3:0] */
dxio_descriptors[WLAN].port_params[3] = 0x122;
}