soc/amd/{cezanne,picasso,stoney}: Clear PM/GPE when enabling ACPI
According to https://uefi.org/specs/ACPI/6.4/16_Waking_and_Sleeping/sleeping-states.html?highlight=power%20states# > For ACPI/legacy systems, when transitioning from the legacy to the G0 > working state this register is cleared by platform firmware prior to > setting the SCI_EN bit. This change makes sure we clear the PM/GPE blocks are cleared before enabling the SCI_EN bit. BUG=b:172021431 TEST=Boot guybrush and morphius to OS and verify suspend resume still works. Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: Icc6f542185dc520f8d181423961b74481c0b5506 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59928 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
parent
9a185e5bfe
commit
c7ab9f410c
|
@ -23,6 +23,7 @@ static void fch_apmc_smi_handler(void)
|
||||||
|
|
||||||
switch (cmd) {
|
switch (cmd) {
|
||||||
case APM_CNT_ACPI_ENABLE:
|
case APM_CNT_ACPI_ENABLE:
|
||||||
|
acpi_clear_pm_gpe_status();
|
||||||
acpi_enable_sci();
|
acpi_enable_sci();
|
||||||
break;
|
break;
|
||||||
case APM_CNT_ACPI_DISABLE:
|
case APM_CNT_ACPI_DISABLE:
|
||||||
|
|
|
@ -23,6 +23,7 @@ static void fch_apmc_smi_handler(void)
|
||||||
|
|
||||||
switch (cmd) {
|
switch (cmd) {
|
||||||
case APM_CNT_ACPI_ENABLE:
|
case APM_CNT_ACPI_ENABLE:
|
||||||
|
acpi_clear_pm_gpe_status();
|
||||||
acpi_enable_sci();
|
acpi_enable_sci();
|
||||||
break;
|
break;
|
||||||
case APM_CNT_ACPI_DISABLE:
|
case APM_CNT_ACPI_DISABLE:
|
||||||
|
|
|
@ -21,6 +21,7 @@ static void fch_apmc_smi_handler(void)
|
||||||
|
|
||||||
switch (cmd) {
|
switch (cmd) {
|
||||||
case APM_CNT_ACPI_ENABLE:
|
case APM_CNT_ACPI_ENABLE:
|
||||||
|
acpi_clear_pm_gpe_status();
|
||||||
acpi_enable_sci();
|
acpi_enable_sci();
|
||||||
break;
|
break;
|
||||||
case APM_CNT_ACPI_DISABLE:
|
case APM_CNT_ACPI_DISABLE:
|
||||||
|
|
Loading…
Reference in New Issue