GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lippert/frontronner-af & toucan-af: Fix IASL warnings 

Not all the paths through the _OSC method returned a value.  According
to the ACPI spec (5.0 & 6.0), bit 2 needs to be set for an unrecognized
GUID.

Fixes warnings for both platforms:
dsdt.aml 1143:  Method(_OSC,4)
Warning  3115 -          ^ Not all control paths return a value (_OSC)
dsdt.aml 1143:  Method(_OSC,4)
Warning  3107 -          ^ Reserved method must return a value
(Buffer required for _OSC)

Change-Id: Ibaf27c5244b1242b4fc1de474c371f54f930dcb6
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12530
Tested-by: build bot (Jenkins)
Reviewed-by: Jens Rottmann <JRottmann@LiPPERTembedded.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Martin Roth 2015-11-24 16:17:11 -07:00
parent b6acc3071f
commit c7b26c381c
4 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/lippert/frontrunner-af/Kconfig
View File

@ -76,8 +76,4 @@ config SB800_AHCI_ROM
bool bool
default n default n
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LIPPERT_FRONTRUNNER_AF endif # BOARD_LIPPERT_FRONTRUNNER_AF

14
src/mainboard/lippert/frontrunner-af/dsdt.asl
View File

@ -1158,14 +1158,22 @@ DefinitionBlock (
Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method (_OSC, 4)
{ /* Check for proper PCI/PCIe UUID */ {
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) /* Check for PCI/PCI-X/PCIe GUID */
If (LEqual (Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} }
Else
{
/* Unrecognized UUID, so set bit 2 of Arg3 to 1 */
CreateDWordField (Arg3, 0, CDW1)
Or (CDW1, 4, CDW1)
Return (Arg3)
} }
} /* End _OSC */
Method(_BBN, 0) { /* Bus number = 0 */ Method(_BBN, 0) { /* Bus number = 0 */
Return(0) Return(0)

4
src/mainboard/lippert/toucan-af/Kconfig
View File

@ -78,8 +78,4 @@ config SB800_AHCI_ROM
bool bool
default n default n
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_LIPPERT_TOUCAN_AF endif # BOARD_LIPPERT_TOUCAN_AF

14
src/mainboard/lippert/toucan-af/dsdt.asl
View File

@ -1158,14 +1158,22 @@ DefinitionBlock (
Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */ Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
/* Operating System Capabilities Method */ /* Operating System Capabilities Method */
Method(_OSC,4) Method (_OSC, 4)
{ /* Check for proper PCI/PCIe UUID */ {
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766"))) /* Check for PCI/PCI-X/PCIe GUID */
If (LEqual (Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{ {
/* Let OS control everything */ /* Let OS control everything */
Return (Arg3) Return (Arg3)
} }
Else
{
/* Unrecognized UUID, so set bit 2 of Arg3 to 1 */
CreateDWordField (Arg3, 0, CDW1)
Or (CDW1, 4, CDW1)
Return (Arg3)
} }
} /* End _OSC */
Method(_BBN, 0) { /* Bus number = 0 */ Method(_BBN, 0) { /* Bus number = 0 */
Return(0) Return(0)