GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86/car: Fix incorrect config usage 

This IS_ENABLED(XXX) line should've clearly been IS_ENABLED(CONFIG_XXX).
This patch fixes the issue. Not tested on a real board, but looking at
the affected code paths suggests that this will result in no effective
change anywhere (since CAR should already be torn down by the time this
is called on FSP1.0 boards, so do_car_migrate_variables() would have
immediately exited anyway).

Change-Id: I74e0ed4d04471ee521ff5c69a74a6f4c949e5847
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31744
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Julius Werner 2019-03-04 18:17:28 -08:00
parent e5861828ee
commit c8aed48127
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpu/x86/car.c
View File

@ -142,7 +142,7 @@ static void do_car_migrate_variables(void)
static void car_migrate_variables(int is_recovery) static void car_migrate_variables(int is_recovery)
{ {
if (!IS_ENABLED(PLATFORM_USES_FSP1_0)) if (!IS_ENABLED(CONFIG_PLATFORM_USES_FSP1_0))
do_car_migrate_variables(); do_car_migrate_variables();
} }
ROMSTAGE_CBMEM_INIT_HOOK(car_migrate_variables) ROMSTAGE_CBMEM_INIT_HOOK(car_migrate_variables)