util/lint: Add linter to keep selects out of Kconfig.name
While having select statements in Kconfig.name files is valid in the syntax of the Kconfig language, having the selections split between the normal Kconfig file and Kconfig.name files makes it harder to see what's going on. Kconfig.name files will now be limited to their original purpose of selecting a particular board or board variant, not actually configuring that board. Signed-off-by: Martin Roth <gaumless@gmail.com> Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78972 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune@9elements.com> Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
parent
7e775cf893
commit
c8dc4a3bd1
1 changed files with 16 additions and 0 deletions
16
util/lint/lint-stable-029-kconfig-name-selects
Executable file
16
util/lint/lint-stable-029-kconfig-name-selects
Executable file
|
@ -0,0 +1,16 @@
|
|||
#!/usr/bin/env sh
|
||||
# SPDX-License-Identifier: GPL-2.0-or-later
|
||||
#
|
||||
# DESCR: Check that boards don't use select Kconfig.name
|
||||
|
||||
export LC_ALL=C
|
||||
FAIL=0
|
||||
|
||||
for board in src/mainboard/*/*; do
|
||||
if [ -f ${board}/Kconfig.name ] && grep -q "select " "${board}/Kconfig.name"; then
|
||||
echo "Mainboard ${board} uses 'select' in Kconfig.name"
|
||||
FAIL=1
|
||||
fi
|
||||
done
|
||||
|
||||
exit ${FAIL}
|
Loading…
Reference in a new issue