GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/rex: update touchscreen report EN pin setting 

Removed workaround since the latest schematics fixed.

Power Sequencing of ELAN6918 (in ACPI) after this patch
`POWER enabled -> RESET deasserted -> Report EN enabled`

BUG=b:247029304
TEST=Verified ELAN touch panel is working as expected after booting
Google/rex device to ChromeOS.

Signed-off-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72725
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Ivy Jian 2023-02-02 10:29:45 +08:00 committed by Eric Lai
parent eed31cbc93
commit c8e0f1631f
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/mainboard/google/rex/variants/rex0/gpio.c
View File

@ -107,20 +107,7 @@ static const struct pad_config gpio_table[] = {
/* GPP_C05 : [] ==> WWAN_PERST_L_STRAP */
PAD_CFG_GPO(GPP_C05, 1, PLTRST),
/* GPP_C06 : [] ==> SOC_TCHSCR_RPT_EN */
/*
* FIXME: Remove this code after resolving b/247029304.
*
* ELAN6918 Power Sequencing seems not perfectly matching
* with the previous platforms and setting GPP_C06 to high prior
* to the power sequencing is actually makes it work.
*
* Ideally Power Sequencing should be as below for ELAN6918 (in ACPI)
* `POWER enabled -> RESET deasserted -> Report EN enabled`
*
* But below sequence is only working currently:
* `Report EN enabled (ramstage) -> POWER enabled (ACPI) -> RESET deasserted (ACPI)`
*/
PAD_CFG_GPO(GPP_C06, 1, DEEP),
PAD_CFG_GPO(GPP_C06, 0, DEEP),
/* GPP_C07 : [] ==> SOC_TCHSCR_INT */
PAD_CFG_GPI_APIC(GPP_C07, NONE, PLTRST, LEVEL, NONE),
/* GPP_C08 : [] ==> SOCHOT_ODL */