From c90d406008c2bd0b947a11530218c0652fd63b55 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Wed, 1 Dec 2021 13:52:25 -0800 Subject: [PATCH] tests: Disable -Wmain-return-type for clang Unit tests fail on clang 13.0 because Cmocka's main() function is declared with return type int, but through some of our chain-include games it sometimes gets coreboot's main_decl.h which declares the function as void. Compilers have traditionally always been very laissez-faire about the signature of the main function, but it seems that clang has been getting more strict by default recently. Explicitly disable the related warning to shut it up. Signed-off-by: Julius Werner Change-Id: I867c9dac659be86e7b7cf4cc41d6fa105aa9ac41 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59815 Tested-by: build bot (Jenkins) Reviewed-by: Jakub Czapiga --- payloads/libpayload/tests/Makefile.inc | 2 +- tests/Makefile.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/payloads/libpayload/tests/Makefile.inc b/payloads/libpayload/tests/Makefile.inc index b59aee6eb6..55c455cf40 100644 --- a/payloads/libpayload/tests/Makefile.inc +++ b/payloads/libpayload/tests/Makefile.inc @@ -43,7 +43,7 @@ TEST_CFLAGS += -I$(cmockasrc)/include TEST_CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wvla TEST_CFLAGS += -Wwrite-strings -Wno-trigraphs -Wimplicit-fallthrough TEST_CFLAGS += -Wstrict-aliasing -Wshadow -Werror -TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr +TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr -Wno-main-return-type TEST_CFLAGS += -std=gnu11 -Os -ffunction-sections -fdata-sections -fno-builtin diff --git a/tests/Makefile.inc b/tests/Makefile.inc index d6258da27a..847beaf199 100644 --- a/tests/Makefile.inc +++ b/tests/Makefile.inc @@ -45,7 +45,7 @@ TEST_CFLAGS += -I$(src) -I$(src)/include -I$(src)/commonlib/include \ # Only put conservative warnings here that really detect code that's obviously # unintentional. TEST_CFLAGS += -Wall -Werror -Wundef -Wstrict-prototypes -Wno-inline-asm -TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr +TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr -Wno-main-return-type # Path for Kconfig autoheader TEST_CFLAGS += -I$(dir $(TEST_KCONFIG_AUTOHEADER))