From c925609c1ea96c740fdbcf9a3241904f5978407f Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 10 Apr 2022 11:21:12 +0200 Subject: [PATCH] mb/ibase/mb899: Drop `_PRS` and `_DIS` from static devices The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object. The no-op `_DIS` methods can also be removed for the same reason. Also, drop `IGNORE_IASL_MISSING_DEPENDENCY` as it's no longer needed. Change-Id: I7e702e9318fbf68dbd883a145111e6beb6815b8b Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/63527 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/mainboard/ibase/mb899/Kconfig | 3 --- src/mainboard/ibase/mb899/acpi/superio.asl | 18 ------------------ 2 files changed, 21 deletions(-) diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index fdfe541f47..05b0a09a0c 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -1,8 +1,5 @@ if BOARD_IBASE_MB899 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_M diff --git a/src/mainboard/ibase/mb899/acpi/superio.asl b/src/mainboard/ibase/mb899/acpi/superio.asl index 488bf18a2c..1932eaba14 100644 --- a/src/mainboard/ibase/mb899/acpi/superio.asl +++ b/src/mainboard/ibase/mb899/acpi/superio.asl @@ -18,15 +18,6 @@ Device (SIO1) Return (0x0f) } - Method (_DIS, 0) { /* NOOP */ } - - Name (_PRS, ResourceTemplate() { - StartDependentFn(0, 1) { - IO(Decode16, 0x3f8, 0x3f8, 0x8, 0x8) - IRQNoFlags() { 4 } - } EndDependentFn() - }) - Method (_CRS, 0) { Return(ResourceTemplate() { @@ -51,15 +42,6 @@ Device (SIO1) Return (0x0f) } - Method (_DIS, 0) { /* NOOP */ } - - Name (_PRS, ResourceTemplate() { - StartDependentFn(0, 1) { - IO(Decode16, 0x2f8, 0x2f8, 0x8, 0x8) - IRQNoFlags() { 3 } - } EndDependentFn() - }) - Method (_CRS, 0) { Return(ResourceTemplate() {