From c9686d22b173ce10951097021c1a14f03ab9bb8a Mon Sep 17 00:00:00 2001 From: Rob Barnes Date: Mon, 20 Sep 2021 07:17:40 -0600 Subject: [PATCH] mb/google/guybrush: Use open drain eSPI alerts Remove the override in guybrush devicetree that configured in-band eSPI alerts. This will result in guybrush using dedicated open-drain eSPI alerts. Guybrush boards must be reworked to connect the eSPI alert line, otherwise they will not boot with this change BUG=b:198596430 TEST=Boot on reworked guybrush BRANCH=None Change-Id: I185eec773336fb662d9fe7f4c11991813e4d7cd6 Signed-off-by: Rob Barnes Reviewed-on: https://review.coreboot.org/c/coreboot/+/57778 Reviewed-by: Felix Held Reviewed-by: Raul Rangel Reviewed-by: Karthik Ramasubramanian Tested-by: build bot (Jenkins) --- .../google/guybrush/variants/guybrush/overridetree.cb | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb index 41b3733e7e..aefdd3d605 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb @@ -169,7 +169,4 @@ chip soc/amd/cezanne end end - # TODO(b/198596430): Disable in-band alerts after majority boards are reworked - register "common_config.espi_config.alert_pin" = "ESPI_ALERT_PIN_IN_BAND" - end # chip soc/amd/cezanne