GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chromeec: Decouple EC tablet event and TBMC device 

This change decouples EC tablet event and TBMC device by guarding
TBMC definition and notification using EC_ENABLE_TBMC_DEVICE. It
allows mainboards to use tablet events without having to define a TBMC
device.

BUG=b:72554519

Change-Id: Ie38b6d68486e8e644dd0d6d406def3ae7fdb5152
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/23461
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
This commit is contained in:
Furquan Shaikh 2018-01-26 10:40:09 -08:00 committed by Furquan Shaikh
parent ec91dd8feb
commit c96ad868d4
4 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/google/chromeec/acpi/ec.asl
View File

@ -365,6 +365,8 @@ Device (EC0)
If (CondRefOf (\_SB.DPTF.TPET)) { If (CondRefOf (\_SB.DPTF.TPET)) {
\_SB.DPTF.TPET() \_SB.DPTF.TPET()
} }
#endif
#ifdef EC_ENABLE_TBMC_DEVICE
Notify (TBMC, 0x80) Notify (TBMC, 0x80)
#endif #endif
} }
@ -517,7 +519,7 @@ Device (EC0)
#include "pd.asl" #include "pd.asl"
#endif #endif
#ifdef EC_ENABLE_TABLET_EVENT #ifdef EC_ENABLE_TBMC_DEVICE
#include "tbmc.asl" #include "tbmc.asl"
#endif #endif
} }

2
src/mainboard/google/eve/ec.h
View File

@ -79,6 +79,8 @@
/* Enable Tablet switch */ /* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT #define EC_ENABLE_TABLET_EVENT
#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */

1
src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
View File

@ -72,6 +72,7 @@
#define EC_ENABLE_LID_SWITCH #define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
#define EC_ENABLE_TABLET_EVENT #define EC_ENABLE_TABLET_EVENT
#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */

2
src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
View File

@ -74,6 +74,8 @@
/* Enable Tablet switch */ /* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT #define EC_ENABLE_TABLET_EVENT
#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */