GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/superiotool: Drop one SCH5317 entry 

The SCH5317 can have either 0x85 or 0x8c as device ID. However, the
former results in false positives on any ITE IT85xx series embedded
controller, which has led some people to think that chip was actually in
their laptops. Moreover, there is no register dump for the SCH5317.

Since nobody has touched this in over a decade, avoid further confusion
by dropping the misleading definition.

Change-Id: I4d1d34d1b88b878461499e52f1a916ee1e33210d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39376
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Angel Pons 2020-03-07 19:55:17 +01:00 committed by Patrick Georgi
parent 9900cf8009
commit c97bf6fdb4
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/superiotool/smsc.c
View File

@ -860,9 +860,6 @@ static const struct superio_registers reg_table[] = {
{EOT}}},
{0x83, "SCH5514D", { /* From sensors-detect */
{EOT}}},
{0x85, "SCH5317", { /* From sensors-detect */
/* The SCH5317 can have either 0x85 or 0x8c as device ID. */
{EOT}}},
{0x86, "SCH5127", { /* From sensors-detect, dump from datasheet */
{NOLDN, NULL,
{0x02,0x03,0x21,0x22,0x23,0x24,0x26,0x27,