GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/abuild: Use realpath for FAILED_BOARDS/PASSED_BOARDS 

The abuild script will `cd` into the build directory. FAILED_BOARDS
defaults to a relative path, so it ends up trying to echo into a
directory that doesn't exist.

If we set the realpath to the file then we can correctly update the
failed/passed boards file.

BUG=none
TEST=make what-jenkins-does and verified there was a failed_boards and
passed_boards in coreboot-builds.

Change-Id: Ib3af003b090668380a9425583a9f4367023820a6
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34526
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Raul E Rangel 2019-07-22 15:09:37 -06:00 committed by Martin Roth
parent eaee392cb3
commit c989e0bd56
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/abuild/abuild
View File

@ -746,13 +746,18 @@ if [ -z "$TARGET" ] || [ "$TARGET" = "/" ]; then
exit 1 exit 1
fi fi
if ! mkdir -p "$TARGET"; then
echo "Unable to create build directory"
exit 1
fi
customizing=$(echo "$customizing" | cut -c3-) customizing=$(echo "$customizing" | cut -c3-)
if [ "$customizing" = "" ]; then if [ "$customizing" = "" ]; then
customizing="default configuration" customizing="default configuration"
fi fi
FAILED_BOARDS="${TARGET}/failed_boards" FAILED_BOARDS="$(realpath ${TARGET}/failed_boards)"
PASSED_BOARDS="${TARGET}/passing_boards" PASSED_BOARDS="$(realpath ${TARGET}/passing_boards)"
if [ "$recursive" = "false" ]; then if [ "$recursive" = "false" ]; then
rm -f "$FAILED_BOARDS" "$PASSED_BOARDS" rm -f "$FAILED_BOARDS" "$PASSED_BOARDS"