From c98c81524ce92450478ca49834356107925cbe23 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 21 Feb 2023 23:02:00 +0100 Subject: [PATCH] sb/amd/pi/hudson/fadt: drop unneeded ARM_boot_arch assignment The FADT data structure is zero-initialized in acpi_create_fadt which then calls the SoC-specific acpi_fill_fadt function, therefore it's not needed to assign 0 to the ARM_boot_arch FADT field in acpi_fill_fadt. Signed-off-by: Felix Held Change-Id: Id2d24a9b8d5b04271eb4da6a622b5bba66dbc501 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73188 Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger --- src/southbridge/amd/pi/hudson/fadt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c index 027ed78b20..4989d6b302 100644 --- a/src/southbridge/amd/pi/hudson/fadt.c +++ b/src/southbridge/amd/pi/hudson/fadt.c @@ -62,8 +62,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0;