GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/{common,apl,glk}: guard PM Timer option on SoCs w/o PM Timer 

Apollo Lake and Gemini Lake do not have a hardware PM ACPI timer but
only uCode PM Timer emulation. Add a Kconfig `NO_PM_ACPI_TIMER` denoting
SoCs without PM Timer and make it mutually exclusive with the Kconfig
`USE_PM_ACPI_TIMER`.

This is partly redundant to `PM_ACPI_TIMER_OPTIONAL`, which will be
dropped in the follow-up change, though.

Change-Id: Ic323bbfb7089c53a6f22724910a0ff3df8904ebd
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57931
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Michael Niewöhner 2021-09-24 23:22:51 +02:00
parent 413810e55f
commit c9a12f2402
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/intel/apollolake/Kconfig
View File

@ -48,6 +48,7 @@ config CPU_SPECIFIC_OPTIONS
select MRC_SETTINGS_PROTECT select MRC_SETTINGS_PROTECT
select MRC_SETTINGS_VARIABLE_DATA select MRC_SETTINGS_VARIABLE_DATA
select NO_XIP_EARLY_STAGES select NO_XIP_EARLY_STAGES
select NO_PM_ACPI_TIMER
select PARALLEL_MP_AP_WORK select PARALLEL_MP_AP_WORK
select PCIEXP_ASPM select PCIEXP_ASPM
select PCIEXP_COMMON_CLOCK select PCIEXP_COMMON_CLOCK

6
src/soc/intel/common/block/pmc/Kconfig
View File

@ -50,6 +50,11 @@ config PMC_GLOBAL_RESET_ENABLE_LOCK
Note that the reset register is still at 0xCF9 this only Note that the reset register is still at 0xCF9 this only
controls the enable and lock feature. controls the enable and lock feature.
config NO_PM_ACPI_TIMER
bool
help
Selected by SoCs that do not have a PM ACPI timer.
config PM_ACPI_TIMER_OPTIONAL config PM_ACPI_TIMER_OPTIONAL
bool bool
default n default n
@ -62,6 +67,7 @@ if PM_ACPI_TIMER_OPTIONAL
config USE_PM_ACPI_TIMER config USE_PM_ACPI_TIMER
bool "Enable ACPI PM timer" bool "Enable ACPI PM timer"
default y default y
depends on !NO_PM_ACPI_TIMER
help help
This should be disabled for devices running on battery since This should be disabled for devices running on battery since
it can draw much power. Further, it must be disabled, if S0ix it can draw much power. Further, it must be disabled, if S0ix