GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/i82801ix/hdaudio.c: Clean up cosmetics 

Reflow some comments and add spaces around an operator.

Tested with BUILD_TIMELESS=1, Roda RK9 does not change.

Change-Id: I655d74ecbefa664d79b1af805f92cbcf877a43ac
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42641
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Angel Pons 2020-06-21 15:38:29 +02:00
parent 3bff419824
commit c9d6333ab6
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/southbridge/intel/i82801ix/hdaudio.c
View File

@ -29,9 +29,7 @@ static int set_bits(void *port, u32 mask, u32 val)
reg32 |= val; reg32 |= val;
write32(port, reg32); write32(port, reg32);
/* Wait for readback of register to /* Wait for readback of register to match what was just written to it */
* match what was just written to it
*/
count = 50; count = 50;
do { do {
/* Wait 1ms based on BKDG wait time */ /* Wait 1ms based on BKDG wait time */
@ -76,7 +74,7 @@ no_codec:
static u32 find_verb(struct device *dev, u32 viddid, const u32 **verb) static u32 find_verb(struct device *dev, u32 viddid, const u32 **verb)
{ {
int idx=0; int idx = 0;
while (idx < (cim_verb_data_size / sizeof(u32))) { while (idx < (cim_verb_data_size / sizeof(u32))) {
u32 verb_size = 4 * cim_verb_data[idx+2]; // in u32 u32 verb_size = 4 * cim_verb_data[idx+2]; // in u32
@ -99,9 +97,7 @@ static u32 find_verb(struct device *dev, u32 viddid, const u32 **verb)
static int wait_for_ready(u8 *base) static int wait_for_ready(u8 *base)
{ {
/* Use a 50 usec timeout - the Linux kernel uses the /* Use a 50 usec timeout - the Linux kernel uses the same duration */
* same duration */
int timeout = 50; int timeout = 50;
while (timeout--) { while (timeout--) {
@ -115,9 +111,8 @@ static int wait_for_ready(u8 *base)
} }
/** /**
* Wait 50usec for the codec to indicate that it accepted * Wait 50usec for the codec to indicate that it accepted the previous command.
* the previous command. No response would imply that the code * No response would imply that the code is non-operative.
* is non-operative
*/ */
static int wait_for_valid(u8 *base) static int wait_for_valid(u8 *base)
@ -129,14 +124,12 @@ static int wait_for_valid(u8 *base)
reg32 |= (1 << 0) | (1 << 1); reg32 |= (1 << 0) | (1 << 1);
write32(base + 0x68, reg32); write32(base + 0x68, reg32);
/* Use a 50 usec timeout - the Linux kernel uses the /* Use a 50 usec timeout - the Linux kernel uses the same duration */
* same duration */
int timeout = 50; int timeout = 50;
while (timeout--) { while (timeout--) {
reg32 = read32(base + HDA_ICII_REG); reg32 = read32(base + HDA_ICII_REG);
if ((reg32 & (HDA_ICII_VALID | HDA_ICII_BUSY)) == if ((reg32 & (HDA_ICII_VALID | HDA_ICII_BUSY)) == HDA_ICII_VALID)
HDA_ICII_VALID)
return 0; return 0;
udelay(1); udelay(1);
} }