From ca4f073f8ee3b7d2bf4d7f1ca63fc5957e6feae2 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Thu, 18 Jul 2013 12:27:00 +0200 Subject: [PATCH] ec/kontron/it8516e: Add sanity checks for values from nvram Change-Id: Ie52d80fc8657064efdcec51c31dc9309fcc28121 Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/3787 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Ronald G. Minnich --- src/ec/kontron/it8516e/ec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c index 721412199d..925b7ea524 100644 --- a/src/ec/kontron/it8516e/ec.c +++ b/src/ec/kontron/it8516e/ec.c @@ -170,6 +170,8 @@ static void it8516e_set_fan_from_options(const config_t *const config, "Setting it8516e fan%d " "control to %d%% PWM.\n", fan_idx + 1, fan_target); + if (fan_target > 100) /* Constrain to 100% */ + fan_target = 100; it8516e_set_fan_pwm(fan_idx, (fan_target * 255) / 100); break; case IT8516E_MODE_SPEED: @@ -183,6 +185,8 @@ static void it8516e_set_fan_from_options(const config_t *const config, printk(BIOS_DEBUG, "Setting it8516e fan%d control to %d C.\n", fan_idx + 1, fan_target); + if (fan_target > 1024) /* Constrain to 1K */ + fan_target = 1024; it8516e_set_fan_temperature(fan_idx, fan_target * 64); fanX_min[3] = '1' + fan_idx;