GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism/librem_skl: Clean up hda_verb.c 

Use the `AZALIA_RESET` macro, write hex values in lowercase and remove
redundant comments. Also express verb length in decimal.

Tested with BUILD_TIMELESS=1, Purism Librem 15 v4 remains identical.

Change-Id: Id9f5ff9614a8f8c0b7f3a3c633a1dcdda8c5876c
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58903
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Angel Pons 2021-11-03 12:37:34 +01:00 committed by Felix Held
parent e13d3548d8
commit ca6e95ce55
1 changed files with 6 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/mainboard/purism/librem_skl/hda_verb.c
View File

@ -6,52 +6,20 @@ const u32 cim_verb_data[] = {
/* coreboot specific header */ /* coreboot specific header */
0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */
0x19910269, /* Subsystem ID */ 0x19910269, /* Subsystem ID */
0x0000000c, /* Number of jacks (NID entries) */ 12, /* Number of jacks (NID entries) */
0x0017ff00, /* Function Reset */ AZALIA_RESET(1),
0x0017ff00, /* Double Function Reset */
0x0017ff00,
0x0017ff00,
/* Bits 31:28 - Codec Address */
/* Bits 27:20 - NID */
/* Bits 19:8 - Verb ID */
/* Bits 7:0 - Payload */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x19910269 */
AZALIA_SUBVENDOR(0, 0x19910269), AZALIA_SUBVENDOR(0, 0x19910269),
/* Pin Widget Verb Table */
/* Pin Complex (NID 0x12) */
AZALIA_PIN_CFG(0, 0x12, 0x40000000), AZALIA_PIN_CFG(0, 0x12, 0x40000000),
/* Pin Complex (NID 0x14) */
AZALIA_PIN_CFG(0, 0x14, 0x90170110), AZALIA_PIN_CFG(0, 0x14, 0x90170110),
/* Pin Complex (NID 0x15) */
AZALIA_PIN_CFG(0, 0x15, 0x04214020), AZALIA_PIN_CFG(0, 0x15, 0x04214020),
/* Pin Complex (NID 0x17) */
AZALIA_PIN_CFG(0, 0x17, 0x411111f0), AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
/* Pin Complex (NID 0x18) */
AZALIA_PIN_CFG(0, 0x18, 0x04a19040), AZALIA_PIN_CFG(0, 0x18, 0x04a19040),
/* Pin Complex (NID 0x19) */
AZALIA_PIN_CFG(0, 0x19, 0x90a70130), AZALIA_PIN_CFG(0, 0x19, 0x90a70130),
AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1A) */ AZALIA_PIN_CFG(0, 0x1b, 0x411111f0),
AZALIA_PIN_CFG(0, 0x1A, 0x411111f0), AZALIA_PIN_CFG(0, 0x1d, 0x40548505),
AZALIA_PIN_CFG(0, 0x1e, 0x411111f0),
/* Pin Complex (NID 0x1B) */
AZALIA_PIN_CFG(0, 0x1B, 0x411111f0),
/* Pin Complex (NID 0x1D) */
AZALIA_PIN_CFG(0, 0x1D, 0x40548505),
/* Pin Complex (NID 0x1E) */
AZALIA_PIN_CFG(0, 0x1E, 0x411111f0),
}; };
const u32 pc_beep_verbs[] = {}; const u32 pc_beep_verbs[] = {};