GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment 

Change-Id: I0f02a4508b78cdb0706df6f288138a9db54e229e
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36703
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2019-11-09 16:50:47 +01:00 committed by Patrick Georgi
parent aabc215962
commit ca7f93d567
3 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/northbridge/intel/fsp_rangeley/northbridge.c
View File

@ -76,7 +76,7 @@ static int get_pcie_bar(u32 *base)
} }
static int add_fixed_resources(struct device *dev, int index) static void add_fixed_resources(struct device *dev, int index)
{ {
struct resource *resource; struct resource *resource;
@ -87,8 +87,6 @@ static int add_fixed_resources(struct device *dev, int index)
IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k);
return index;
} }
static void mc_add_dram_resources(struct device *dev) static void mc_add_dram_resources(struct device *dev)
@ -133,7 +131,7 @@ static void mc_add_dram_resources(struct device *dev)
printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (bmbound_hi - 0x100000000) >> 20); printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (bmbound_hi - 0x100000000) >> 20);
} }
index = add_fixed_resources(dev, index); add_fixed_resources(dev, index);
} }
static void mc_read_resources(struct device *dev) static void mc_read_resources(struct device *dev)

6
src/soc/intel/fsp_baytrail/northcluster.c
View File

@ -102,7 +102,7 @@ static int get_pcie_bar(u32 *base)
} }
static int add_fixed_resources(struct device *dev, int index) static void add_fixed_resources(struct device *dev, int index)
{ {
struct resource *resource; struct resource *resource;
@ -113,8 +113,6 @@ static int add_fixed_resources(struct device *dev, int index)
IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k);
return index;
} }
static void mc_add_dram_resources(struct device *dev) static void mc_add_dram_resources(struct device *dev)
@ -157,7 +155,7 @@ static void mc_add_dram_resources(struct device *dev)
printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", printk(BIOS_INFO, "Available memory above 4GB: %lluM\n",
highmem_size >> 20); highmem_size >> 20);
index = add_fixed_resources(dev, index); add_fixed_resources(dev, index);
} }
static void nc_read_resources(struct device *dev) static void nc_read_resources(struct device *dev)

6
src/soc/intel/fsp_broadwell_de/northcluster.c
View File

@ -30,7 +30,7 @@
static const int legacy_hole_base_k = 0xa0000 / 1024; static const int legacy_hole_base_k = 0xa0000 / 1024;
static const int legacy_hole_size_k = 384; static const int legacy_hole_size_k = 384;
static int add_fixed_resources(struct device *dev, int index) static void add_fixed_resources(struct device *dev, int index)
{ {
struct resource *resource; struct resource *resource;
u32 pcie_config_base, pcie_config_size; u32 pcie_config_base, pcie_config_size;
@ -52,8 +52,6 @@ static int add_fixed_resources(struct device *dev, int index)
IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k);
return index;
} }
static void mc_add_dram_resources(struct device *dev) static void mc_add_dram_resources(struct device *dev)
@ -117,7 +115,7 @@ static void mc_add_dram_resources(struct device *dev)
printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", printk(BIOS_INFO, "Available memory above 4GB: %lluM\n",
highmem_size >> 20); highmem_size >> 20);
index = add_fixed_resources(dev, index); add_fixed_resources(dev, index);
} }
static void nc_read_resources(struct device *dev) static void nc_read_resources(struct device *dev)