GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd: Remove some extraneous parentheses from if-statements 

Spotted by Clang.

Change-Id: I38832da7b93d4ee18b8de3e80dc39513a8910221
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6149
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Edward O'Callaghan 2014-06-28 17:52:34 +10:00
parent 4d7539eefd
commit caac5ef86d
4 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/amd/agesa/family10/northbridge.c
View File

@ -191,7 +191,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for (index=0; index<64; index++) { for (index=0; index<64; index++) {
if ((sysconf.conf_mmio_addrx[index+8] == 0)) { if (sysconf.conf_mmio_addrx[index+8] == 0) {
sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ;
sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4);
return index; return index;

4
src/northbridge/amd/agesa/family12/amdfam12_conf.c
View File

@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for(index=0; index<256; index++) { for(index=0; index<256; index++) {
if((sysconf.conf_io_addrx[index+4] == 0)){ if(sysconf.conf_io_addrx[index+4] == 0) {
sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ;
sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4);
return index; return index;
@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for(index=0; index<64; index++) { for(index=0; index<64; index++) {
if((sysconf.conf_mmio_addrx[index+8] == 0)){ if(sysconf.conf_mmio_addrx[index+8] == 0) {
sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ;
sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4);
return index; return index;

4
src/northbridge/amd/agesa/family14/amdfam14_conf.c
View File

@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for(index=0; index<256; index++) { for(index=0; index<256; index++) {
if((sysconf.conf_io_addrx[index+4] == 0)){ if(sysconf.conf_io_addrx[index+4] == 0) {
sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ;
sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4);
return index; return index;
@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for(index=0; index<64; index++) { for(index=0; index<64; index++) {
if((sysconf.conf_mmio_addrx[index+8] == 0)){ if(sysconf.conf_mmio_addrx[index+8] == 0) {
sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ;
sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4);
return index; return index;

7
src/northbridge/amd/amdfam10/conf.c
View File

@ -689,7 +689,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn)
u32 index; u32 index;
for(index=0; index<256; index++) { for(index=0; index<256; index++) {
if((sysconf.conf_io_addrx[index+4] == 0)){ if(sysconf.conf_io_addrx[index+4] == 0) {
sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ;
sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4);
return index; return index;
@ -697,16 +697,14 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn)
} }
return 0; return 0;
} }
static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) static u32 get_mmio_addr_index(u32 nodeid, u32 linkn)
{ {
u32 index; u32 index;
for(index=0; index<64; index++) { for(index=0; index<64; index++) {
if((sysconf.conf_mmio_addrx[index+8] == 0)){ if(sysconf.conf_mmio_addrx[index+8] == 0) {
sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ;
sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4);
return index; return index;
@ -714,7 +712,6 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn)
} }
return 0; return 0;
} }
static void store_conf_io_addr(u32 nodeid, u32 linkn, u32 reg, u32 index, static void store_conf_io_addr(u32 nodeid, u32 linkn, u32 reg, u32 index,