GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Pass reference of object to BBST() method 

The BBST() method writes an updated status flag mask that is intended
to be stored back in the battery object.  This value needs to be
passed as a reference to an object to prevent it from being evaluated
at the time the method is loaded or it will not actually update the
BSTP value in the battery device.

This was tested by instrumenting the _BST method in the primary
battery and ensuring the value can be updated by the BBST method.

Change-Id: Ia8e207a2990059a60d96d8e0f3ed3c16a55c50f4
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34356
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Duncan Laurie 2019-07-15 17:37:09 -07:00 committed by Martin Roth
parent 55471147e5
commit cacecefb27
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ec/google/chromeec/acpi/battery.asl
View File

@ -194,7 +194,7 @@ Method (BBST, 4, Serialized)
Store (Local1, Index (Arg1, 0)) Store (Local1, Index (Arg1, 0))
// Notify if battery state has changed since last time // Notify if battery state has changed since last time
If (LNotEqual (Local1, Arg2)) { If (LNotEqual (Local1, DeRefOf (Arg2))) {
Store (Local1, Arg2) Store (Local1, Arg2)
If (LEqual(Arg0, 0)) { If (LEqual(Arg0, 0)) {
Notify (BAT0, 0x80) Notify (BAT0, 0x80)
@ -326,7 +326,7 @@ Device (BAT0)
Method (_BST, 0, Serialized) Method (_BST, 0, Serialized)
{ {
Return (BBST (0, PBST, BSTP, BFWK)) Return (BBST (0, PBST, RefOf (BSTP), BFWK))
} }
} }
@ -416,7 +416,7 @@ Device (BAT1)
Method (_BST, 0, Serialized) Method (_BST, 0, Serialized)
{ {
Return (BBST (1, PBST, BSTP, BFWK)) Return (BBST (1, PBST, RefOf (BSTP), BFWK))
} }
} }
#endif #endif