GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nyan: Ignore the recovery GPIO. 

CrOS devices with Chromeos EC need only use hostevent to communicate
recovery assertion to the BIOS.  This CL removes wired GPIO from
determining recovery as it appears under certain conditions (cold
reset) the internal PU on the AP isn't strong enough and therefore the
value is sometimes seen as asserted.

BRANCH=none
BUG=chrome-os-partner:29333
TEST=compiles & BIOS no longer responds to rec_mode GPIO during boot.

Original-Change-Id: Ib220cfa5f5bfe7193d555bfd32c0444b063d00f2
Original-Signed-off-by: Todd Broch <tbroch@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/202996
Original-Reviewed-by: David Hendricks <dhendrix@chromium.org>
Original-Reviewed-by: Tom Warren <twarren@nvidia.com>
(cherry picked from commit d9927bcd67b0fb069fde231314e654d727092282)
Signed-off-by: Marc Jones <marc.jones@se-eng.com>

Change-Id: I6e086cbabc884f18deb2791a0f897e332b31032f
Reviewed-on: http://review.coreboot.org/8042
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Todd Broch 2014-06-06 17:03:49 -07:00 committed by Marc Jones
parent 8ec74a39fa
commit cb2351ea1f
3 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/nyan/chromeos.c
View File

@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
{ {
uint32_t ec_events; uint32_t ec_events;
/* The GPIO is active low. */
if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
return 1;
ec_events = google_chromeec_get_events_b(); ec_events = google_chromeec_get_events_b();
return !!(ec_events & return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));

4
src/mainboard/google/nyan_big/chromeos.c
View File

@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
{ {
uint32_t ec_events; uint32_t ec_events;
/* The GPIO is active low. */
if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
return 1;
ec_events = google_chromeec_get_events_b(); ec_events = google_chromeec_get_events_b();
return !!(ec_events & return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));

4
src/mainboard/google/nyan_blaze/chromeos.c
View File

@ -88,10 +88,6 @@ int get_recovery_mode_switch(void)
{ {
uint32_t ec_events; uint32_t ec_events;
/* The GPIO is active low. */
if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
return 1;
ec_events = google_chromeec_get_events_b(); ec_events = google_chromeec_get_events_b();
return !!(ec_events & return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));