lenovo/x60: Remove duplicate console_init()

For romstage, console_init() was called twice. The one in dock_connect()
should have done only UART programming and not touch CBMEM console and/or
USBDEBUG when those are enabled.

Second case where dock_connect() is called is in SMI handler.
If DEBUG_SMI is not enabled, console_init() does nothing in SMM.
If DEBUG_SMI is enabled, console_init() is already called every time when
enterining SMM.

Change-Id: Ib3a842442cb7a5be9d6b71682cd6f368930af886
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/5433
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
This commit is contained in:
Kyösti Mälkki 2014-03-31 00:09:23 +03:00 committed by Patrick Georgi
parent c814be4158
commit cb3ba5fdbc
1 changed files with 0 additions and 1 deletions

View File

@ -237,7 +237,6 @@ int dock_connect(void)
dock_write_register(0x07, 0x03); dock_write_register(0x07, 0x03);
dock_write_register(0x30, 0x01); dock_write_register(0x30, 0x01);
console_init();
return 0; return 0;
} }