GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/lpc/espi_util: use __fallthrough 

Using __fallthrough instead of a comment about the fall-through being
intentional should make clang stop complaining about intended fall-
through statements.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I940529be02e20c72f6e97b2cfa10f0dd8f7020b6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62216
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
This commit is contained in:
Felix Held 2022-02-21 16:44:48 +01:00
parent 6f4a5454ac
commit cbaf753012
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/amd/common/block/lpc/espi_util.c
View File

@ -640,7 +640,7 @@ static void espi_set_io_mode_config(enum espi_io_mode mb_io_mode, uint32_t slave
break; break;
} }
printk(BIOS_ERR, "eSPI Quad I/O not supported. Dropping to dual mode.\n"); printk(BIOS_ERR, "eSPI Quad I/O not supported. Dropping to dual mode.\n");
/* Intentional fall-through */ __fallthrough;
case ESPI_IO_MODE_DUAL: case ESPI_IO_MODE_DUAL:
if (espi_slave_supports_dual_io(slave_caps)) { if (espi_slave_supports_dual_io(slave_caps)) {
*slave_config |= ESPI_SLAVE_IO_MODE_SEL_DUAL; *slave_config |= ESPI_SLAVE_IO_MODE_SEL_DUAL;
@ -648,7 +648,7 @@ static void espi_set_io_mode_config(enum espi_io_mode mb_io_mode, uint32_t slave
break; break;
} }
printk(BIOS_ERR, "eSPI Dual I/O not supported. Dropping to single mode.\n"); printk(BIOS_ERR, "eSPI Dual I/O not supported. Dropping to single mode.\n");
/* Intentional fall-through */ __fallthrough;
case ESPI_IO_MODE_SINGLE: case ESPI_IO_MODE_SINGLE:
/* Single I/O mode is always supported. */ /* Single I/O mode is always supported. */
*slave_config |= ESPI_SLAVE_IO_MODE_SEL_SINGLE; *slave_config |= ESPI_SLAVE_IO_MODE_SEL_SINGLE;
@ -672,7 +672,7 @@ static void espi_set_op_freq_config(enum espi_op_freq mb_op_freq, uint32_t slave
break; break;
} }
printk(BIOS_ERR, "eSPI 66MHz not supported. Dropping to 33MHz.\n"); printk(BIOS_ERR, "eSPI 66MHz not supported. Dropping to 33MHz.\n");
/* Intentional fall-through */ __fallthrough;
case ESPI_OP_FREQ_33_MHZ: case ESPI_OP_FREQ_33_MHZ:
if (slave_max_speed_mhz >= 33) { if (slave_max_speed_mhz >= 33) {
*slave_config |= ESPI_SLAVE_OP_FREQ_SEL_33_MHZ; *slave_config |= ESPI_SLAVE_OP_FREQ_SEL_33_MHZ;
@ -680,7 +680,7 @@ static void espi_set_op_freq_config(enum espi_op_freq mb_op_freq, uint32_t slave
break; break;
} }
printk(BIOS_ERR, "eSPI 33MHz not supported. Dropping to 16MHz.\n"); printk(BIOS_ERR, "eSPI 33MHz not supported. Dropping to 16MHz.\n");
/* Intentional fall-through */ __fallthrough;
case ESPI_OP_FREQ_16_MHZ: case ESPI_OP_FREQ_16_MHZ:
/* /*
* eSPI spec says the minimum frequency is 20MHz, but AMD datasheets support * eSPI spec says the minimum frequency is 20MHz, but AMD datasheets support
@ -691,7 +691,7 @@ static void espi_set_op_freq_config(enum espi_op_freq mb_op_freq, uint32_t slave
*ctrlr_config |= ESPI_OP_FREQ_16_MHZ; *ctrlr_config |= ESPI_OP_FREQ_16_MHZ;
break; break;
} }
/* Intentional fall-through */ __fallthrough;
default: default:
die("No supported eSPI Operating Frequency!\n"); die("No supported eSPI Operating Frequency!\n");
} }