GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/starlabs/merlin: Unconditionally enable the Keyboard Backlight 

KBL_STATE was originally intended to provide more granular control
of the keyboard backlight. However, KBL_BRIGHTNESS has a valid value
of "off" which achieves the same thing.

Therefore, unconditionally set the KBL_STATE to enabled, and rely on
KBL_BRIGHTNESS.

Change-Id: Ic7ee6b96b1dcaa6633b111e92097bce87908885e
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77201
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2023-08-16 09:25:42 +01:00 committed by Felix Held
parent 2951447208
commit cbedae116c
2 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ec/starlabs/merlin/ite.c
View File

@ -295,17 +295,11 @@ static void merlin_init(struct device *dev)
* Values: Off, On * Values: Off, On
* Default: On * Default: On
* *
* Note: Always enable, as the brightness level of `off` disables it.
*
*/ */
const uint8_t kbl_state[] = {
KBL_DISABLED,
KBL_ENABLED
};
ec_write(ECRAM_KBL_STATE, ec_write(ECRAM_KBL_STATE, KBL_ENABLED);
get_ec_value_from_option("kbl_state",
1,
kbl_state,
ARRAY_SIZE(kbl_state)));
} }
static struct device_operations ops = { static struct device_operations ops = {

12
src/ec/starlabs/merlin/nuvoton.c
View File

@ -256,17 +256,11 @@ static void merlin_init(struct device *dev)
* Values: Off, On * Values: Off, On
* Default: On * Default: On
* *
* Note: Always enable, as the brightness level of `off` disables it.
*
*/ */
const uint8_t kbl_state[] = {
KBL_DISABLED,
KBL_ENABLED
};
ec_write(ECRAM_KBL_STATE, ec_write(ECRAM_KBL_STATE, KBL_ENABLED);
get_ec_value_from_option("kbl_state",
1,
kbl_state,
ARRAY_SIZE(kbl_state)));
} }
static struct device_operations ops = { static struct device_operations ops = {