mb/clevo/l140cu: Move FSP-M config hook to mainboard level

Hook up FSP-M configuration on mainboard level instead of variant level
being able to do common configuration there.

Also, hook up variant romstage.c on mainboard level for variant
specific configurations.

Change-Id: Ic161f83cb629b1e70ca670e10975a25bc0949656
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
Felix Singer 2021-01-04 05:38:43 +01:00 committed by Michael Niewöhner
parent 24f4623384
commit cbfcb2a6bb
5 changed files with 22 additions and 3 deletions

View File

@ -3,6 +3,9 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
bootblock-y += bootblock.c bootblock-y += bootblock.c
bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c
romstage-y += romstage.c
romstage-y += variants/$(VARIANT_DIR)/romstage.c
ramstage-y += ramstage.c ramstage-y += ramstage.c
ramstage-y += variants/$(VARIANT_DIR)/gpio.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c
ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c

View File

@ -0,0 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#ifndef VARIANT_ROMSTAGE_H
#define VARIANT_ROMSTAGE_H
void variant_configure_fspm(FSPM_UPD *memupd);
#endif

View File

@ -0,0 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <soc/romstage.h>
#include <variant/romstage.h>
void mainboard_memory_init_params(FSPM_UPD *memupd)
{
variant_configure_fspm(memupd);
}

View File

@ -1,2 +1 @@
romstage-y += romstage.c
SPD_SOURCES = samsung-K4AAG165WA-BCTD SPD_SOURCES = samsung-K4AAG165WA-BCTD

View File

@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
#include <soc/cnl_memcfg_init.h> #include <soc/cnl_memcfg_init.h>
#include <soc/romstage.h> #include <variant/romstage.h>
static const struct cnl_mb_cfg memcfg = { static const struct cnl_mb_cfg memcfg = {
.spd[0] = { .spd[0] = {
@ -29,7 +29,7 @@ static const struct cnl_mb_cfg memcfg = {
.vref_ca_config = 2, .vref_ca_config = 2,
}; };
void mainboard_memory_init_params(FSPM_UPD *memupd) void variant_configure_fspm(FSPM_UPD *memupd)
{ {
cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg); cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg);
} }