From cc761e84af6b94795a7eae8ed476e93b687d47d2 Mon Sep 17 00:00:00 2001 From: Brian Norris Date: Wed, 7 Mar 2018 13:11:47 -0800 Subject: [PATCH] google/scarlet: Adjust K&D power sequence from software Hardware updates have suggested we need to configure the K&D panel's power sequence in software, not in hardware. Without this change, K&D panels will no longer power on correctly and will instead display a black screen. Per K&D's suggestion, we tweak these two commands. From the little HW docs I have, this looks like it's: (Address 0xB7, Value 0x02) -> set BC_CTRL=bit(1) (Back light control) to 1 (Address 0xF1, Value 0x22) -> change GPO2_SEL=bits(0:3) from MIPI_TE(0001b) to BC_CTRL (0010b) BRANCH=scarlet BUG=b:73133861 TEST=KD display with and without HW fix on Scarlet Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Signed-off-by: Brian Norris Reviewed-on: https://review.coreboot.org/25023 Reviewed-by: Patrick Georgi Reviewed-by: Matthias Kaehlcke Reviewed-by: Julius Werner Tested-by: build bot (Jenkins) --- src/mainboard/google/gru/mainboard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index 7cd9acd589..c9f3c4891f 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -493,6 +493,7 @@ static struct panel_init_command kd097d04_init_commands[] = { MIPI_INIT_CMD(0xB4, 0x00), MIPI_INIT_CMD(0xB6, 0x80), /* VCOM disable */ + MIPI_INIT_CMD(0xB7, 0x02), MIPI_INIT_CMD(0xB8, 0x80), MIPI_INIT_CMD(0xBA, 0x43), /* VCOM setting */ @@ -506,7 +507,7 @@ static struct panel_init_command kd097d04_init_commands[] = { /* VGL setting */ MIPI_INIT_CMD(0xBF, 0x1A), MIPI_INIT_CMD(0xF0, 0x39), - MIPI_INIT_CMD(0xF1, 0x21), + MIPI_INIT_CMD(0xF1, 0x22), /* Gamma setting */ MIPI_INIT_CMD(0xB0, 0x02), MIPI_INIT_CMD(0xC0, 0x00),