From cc991c58cf409d63cdf2d4c1fba978c97842b989 Mon Sep 17 00:00:00 2001 From: Jonathon Hall Date: Tue, 20 Dec 2022 11:07:19 -0500 Subject: [PATCH] mb/purism/librem_cnl: Remove unneeded explicit PNP enable for UART MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove explicit PNP 6e.1 configuration for UART. This had no effect, the SuperIO is actually on I/O port 2e. Enabling the 8250IO driver is sufficient to use the UART, the UART device is enabled by default. Test: Build Mini v2 with and without CONFIG_ENABLE_EC_UART1, boot and check output on serial. Change-Id: Idbb39c81cadd633f4718f0682d231dc578d20325 Signed-off-by: Jonathon Hall Reviewed-on: https://review.coreboot.org/c/coreboot/+/74362 Reviewed-by: Kyösti Mälkki Tested-by: build bot (Jenkins) --- .../librem_cnl/variants/librem_mini/Makefile.inc | 1 - .../librem_cnl/variants/librem_mini/com_init.c | 13 ------------- 2 files changed, 14 deletions(-) delete mode 100644 src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc b/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc index 59020ef001..20ff43819f 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/Makefile.inc @@ -2,4 +2,3 @@ all-y += die.c smm-y += die.c -bootblock-$(CONFIG_ENABLE_EC_UART1) += com_init.c diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c deleted file mode 100644 index 6d0f79f843..0000000000 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/com_init.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */ - -void bootblock_mainboard_early_init(void) -{ - /* Enable the serial port inside the EC */ - pnp_set_logical_device(SERIAL_DEV); - pnp_set_enable(SERIAL_DEV, 1); -}