GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amdfwtool: Remove the limit of spliting EFS and body 

To support 32M flash, the non-vboot also need to split amdfw. Just as
the deleted comment says, we need this feature now.

This is one of series of patches to support 32/64M flash.
BUG=b:255374782

Change-Id: Ic058cfaeebd1a947227cfa9be2db4eb22702aa28
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69857
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Zheng Bao 2023-02-15 10:11:46 +08:00 committed by Fred Reitberger
parent 69ea83c3c5
commit cd25ca09f0
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
util/amdfwtool/amdfwtool.c
View File

@ -2423,17 +2423,6 @@ int main(int argc, char **argv)
return 1; return 1;
} }
/*
* On boards using vboot, there can be more than one instance of EFS + AMDFW Body.
* For the instance in the RO section, there is no need to split EFS + AMDFW body
* currently. This condition is to ensure that it is not accidentally split. Revisit
* this condition if such a need arises in the future.
*/
if (!any_location && body_location != efs_location) {
fprintf(stderr, "Error: EFS cannot be separate from AMDFW Body.\n");
return 1;
}
if (body_location != efs_location && if (body_location != efs_location &&
body_location < ALIGN(efs_location + sizeof(embedded_firmware), BLOB_ALIGNMENT)) { body_location < ALIGN(efs_location + sizeof(embedded_firmware), BLOB_ALIGNMENT)) {
fprintf(stderr, "Error: Insufficient space between EFS and Blobs.\n"); fprintf(stderr, "Error: Insufficient space between EFS and Blobs.\n");