From cd3a99eaf96ac632426aff0b838f62b72ee3ca12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20=C5=BBygowski?= Date: Fri, 18 Nov 2022 17:33:45 +0100 Subject: [PATCH] mb/msi/ms7d25: Disable DMI ASPM MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disable DMI link ASPM which can degrade performance of overall system. Desktop does not need to be concerned that much about idle power consumption. Signed-off-by: Michał Żygowski Change-Id: I60af9d2ab2913db449059e1e007999fa2f307f5d Reviewed-on: https://review.coreboot.org/c/coreboot/+/69826 Reviewed-by: Paul Menzel Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/mainboard/msi/ms7d25/mainboard.c | 3 +++ src/mainboard/msi/ms7d25/romstage_fsp_params.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index ee781d5856..7e865331ef 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -78,6 +78,9 @@ void mainboard_silicon_init_params(FSP_S_CONFIG *params) params->PcieRpFunctionSwap = 0; params->CpuPcieRpFunctionSwap = 0; + params->PchLegacyIoLowLatency = 1; + params->PchDmiAspmCtrl = 0; + params->CpuPcieRpPmSci[0] = 1; // M2_1 params->CpuPcieRpPmSci[1] = 1; // PCI_E1 params->PcieRpPmSci[0] = 1; // PCI_E2 diff --git a/src/mainboard/msi/ms7d25/romstage_fsp_params.c b/src/mainboard/msi/ms7d25/romstage_fsp_params.c index b9b8206b83..833ff1ac97 100644 --- a/src/mainboard/msi/ms7d25/romstage_fsp_params.c +++ b/src/mainboard/msi/ms7d25/romstage_fsp_params.c @@ -55,6 +55,8 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) memupd->FspmConfig.CpuPcieRpClockReqMsgEnable[1] = 1; memupd->FspmConfig.CpuPcieRpClockReqMsgEnable[2] = 0; memupd->FspmConfig.DmiMaxLinkSpeed = 4; // Gen4 speed, undocumented + memupd->FspmConfig.DmiAspm = 0; + memupd->FspmConfig.DmiAspmCtrl = 0; memupd->FspmConfig.SkipExtGfxScan = 0; memupd->FspmConfig.PchHdaSdiEnable[0] = 1;