GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: Add counter initializers 

Some counters are not being initialized and are relying on mainboards to
set their values.  If the mainboards have not implemented these
functions it leads to indeterminate behavior.

BUG=b:224987813
TEST=builds

Signed-off-by: Jon Murphy <jpmurphy@google.com>
Change-Id: I14903980fd921cad24c39cadd533349c14cc1cd3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62871
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Jon Murphy 2022-03-16 11:00:13 -06:00 committed by Felix Held
parent 2e1d16828a
commit cd93e8e67f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/amd/picasso/fsp_s_params.c
View File

@ -92,10 +92,10 @@ static void fill_ddi_descriptors(FSP_S_CONFIG *scfg,
static void fsp_fill_pcie_ddi_descriptors(FSP_S_CONFIG *scfg) static void fsp_fill_pcie_ddi_descriptors(FSP_S_CONFIG *scfg)
{ {
const fsp_dxio_descriptor *fsp_dxio; const fsp_dxio_descriptor *fsp_dxio = NULL;
const fsp_ddi_descriptor *fsp_ddi; const fsp_ddi_descriptor *fsp_ddi = NULL;
size_t num_dxio; size_t num_dxio = 0;
size_t num_ddi; size_t num_ddi = 0;
mainboard_get_dxio_ddi_descriptors(&fsp_dxio, &num_dxio, mainboard_get_dxio_ddi_descriptors(&fsp_dxio, &num_dxio,
&fsp_ddi, &num_ddi); &fsp_ddi, &num_ddi);