GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge/bootblock/bootblock.c: Fix unused value 

In function load_smu_fw1(), variable base receives one value and is
immediately overwritten. Remove the first line, as it's useless.

This fixes CID 1383612

BUG=b:70620140
TEST=Build kahlee and boot.

Change-Id: I1a1eae52722606a9e871e26faa7927e207102ae8
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/22873
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Richard Spiegel 2017-12-14 09:58:41 -07:00 committed by Aaron Durbin
parent 4dee7b528d
commit ce90c0df41
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/amd/stoneyridge/bootblock/bootblock.c
View File

@ -91,7 +91,6 @@ static void load_smu_fw1(void)
u32 base, limit; u32 base, limit;
/* Open a posted hole from 0x80000000 : 0xfed00000-1 */ /* Open a posted hole from 0x80000000 : 0xfed00000-1 */
base = 0x80000000;
base = (0x80000000 >> 8) | MMIO_WE | MMIO_RE; base = (0x80000000 >> 8) | MMIO_WE | MMIO_RE;
limit = (ALIGN_DOWN(HPET_BASE_ADDRESS - 1, 64 * KiB) >> 8); limit = (ALIGN_DOWN(HPET_BASE_ADDRESS - 1, 64 * KiB) >> 8);
pci_write_config32(SOC_ADDR_DEV, D18F1_MMIO_LIMIT0_LO, limit); pci_write_config32(SOC_ADDR_DEV, D18F1_MMIO_LIMIT0_LO, limit);