GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/mtrr: Remove var-MTRR alignment optimization 

The code used to split up ranges >64MiB into 64MiB-aligned and
unaligned parts. However in its current state the next step,
calc_var_mtrr_range(), results in the same allocation, no mat-
ter if we split the range up before. So just drop the split-up.

Change-Id: I5481fbf3168cdf789879064077b63bbfcaf122c9
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/21914
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Nico Huber 2017-10-06 19:08:51 +02:00 committed by Martin Roth
parent a41277d1d3
commit ceb52711d7
1 changed files with 10 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/cpu/x86/mtrr/mtrr.c
View File

@ -552,60 +552,32 @@ static void calc_var_mtrrs_with_hole(struct var_mtrr_state *var_state,
static void calc_var_mtrrs_without_hole(struct var_mtrr_state *var_state, static void calc_var_mtrrs_without_hole(struct var_mtrr_state *var_state,
struct range_entry *r) struct range_entry *r)
{ {
uint32_t a1, a2, b1, b2, c1, c2; const int mtrr_type = range_entry_mtrr_type(r);
int mtrr_type;
/* uint32_t base = range_entry_base_mtrr_addr(r);
* For each range that meets the non-default type process it in the uint32_t end = range_entry_end_mtrr_addr(r);
* following manner:
* +------------------+ c2 = end
* | 0 or more bytes |
* +------------------+ b2 = c1 = ALIGN_DOWN(end)
* | |
* +------------------+ b1 = a2 = ALIGN_UP(begin)
* | 0 or more bytes |
* +------------------+ a1 = begin
*
* Thus, there are 3 sub-ranges to configure variable MTRRs for.
*/
mtrr_type = range_entry_mtrr_type(r);
a1 = range_entry_base_mtrr_addr(r);
c2 = range_entry_end_mtrr_addr(r);
/* The end address is within the first 1MiB. The fixed MTRRs take /* The end address is within the first 1MiB. The fixed MTRRs take
* precedence over the variable ones. Therefore this range * precedence over the variable ones. Therefore this range
* can be ignored. */ * can be ignored. */
if (c2 <= RANGE_1MB) if (end <= RANGE_1MB)
return; return;
/* Again, the fixed MTRRs take precedence so the beginning /* Again, the fixed MTRRs take precedence so the beginning
* of the range can be set to 0 if it starts at or below 1MiB. */ * of the range can be set to 0 if it starts at or below 1MiB. */
if (a1 <= RANGE_1MB) if (base <= RANGE_1MB)
a1 = 0; base = 0;
/* If the range starts above 4GiB the processing is done. */ /* If the range starts above 4GiB the processing is done. */
if (!var_state->above4gb && a1 >= RANGE_4GB) if (!var_state->above4gb && base >= RANGE_4GB)
return; return;
/* Clip the upper address to 4GiB if addresses above 4GiB /* Clip the upper address to 4GiB if addresses above 4GiB
* are not being processed. */ * are not being processed. */
if (!var_state->above4gb && c2 > RANGE_4GB) if (!var_state->above4gb && end > RANGE_4GB)
c2 = RANGE_4GB; end = RANGE_4GB;
/* Don't align up or down on the range if it is smaller calc_var_mtrr_range(var_state, base, end - base, mtrr_type);
* than the minimum granularity. */
if ((c2 - a1) < MTRR_MIN_ALIGN) {
calc_var_mtrr_range(var_state, a1, c2 - a1, mtrr_type);
return;
}
b1 = a2 = ALIGN_UP(a1, MTRR_MIN_ALIGN);
b2 = c1 = ALIGN_DOWN(c2, MTRR_MIN_ALIGN);
calc_var_mtrr_range(var_state, a1, a2 - a1, mtrr_type);
calc_var_mtrr_range(var_state, b1, b2 - b1, mtrr_type);
calc_var_mtrr_range(var_state, c1, c2 - c1, mtrr_type);
} }
static void __calc_var_mtrrs(struct memranges *addr_space, static void __calc_var_mtrrs(struct memranges *addr_space,