mb/google/brya/var/*: Ensure LCD device has a valid address

Some variants added the generic gfx driver with an LCD device without
specifying the address, which is required for the backlight controls
to be functional under Windows. Add the address value where missing.

Address value used (0x80010400) is same as on other Brya variants which
did properly set it, and is taken from the ACPI 6.5 spec section B.4.2,
_DOD (display output device enumeration), table B-2:

- bit 31 = use the ACPI-defined (vs vendor-defined) bit scheme for bits
  15-0
- bit 16 = platform firmware can detect the device
- bit 10 = display type is internal/integrated flat panel (aka LCD)

TEST=build/boot Win11 on google/brya (osiris), verify ACPI backlight
controls functional.

Change-Id: Id24e330cfb7c993d12665a704e1ca78e2e38874f
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80062
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Matt DeVillier 2024-01-16 18:46:20 -06:00 committed by Felix Held
parent b6cbfa977f
commit cf29efabba
25 changed files with 50 additions and 0 deletions

View file

@ -118,6 +118,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -100,6 +100,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -200,6 +200,8 @@ chip soc/intel/alderlake
register "device_count" = "4"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

View file

@ -99,6 +99,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -123,6 +123,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

View file

@ -112,6 +112,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -92,6 +92,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -98,6 +98,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0

View file

@ -79,6 +79,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -44,6 +44,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -101,6 +101,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -146,6 +146,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -96,6 +96,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0

View file

@ -131,6 +131,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -75,6 +75,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -87,6 +87,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -133,6 +133,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -114,6 +114,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

View file

@ -122,6 +122,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

View file

@ -117,6 +117,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

View file

@ -142,6 +142,8 @@ chip soc/intel/alderlake
register "device_count" = "3"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

View file

@ -123,6 +123,8 @@ chip soc/intel/alderlake
register "device_count" = "3"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

View file

@ -119,6 +119,8 @@ chip soc/intel/alderlake
register "device_count" = "3"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

View file

@ -98,6 +98,8 @@ chip soc/intel/alderlake
register "device_count" = "5"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

View file

@ -93,6 +93,8 @@ chip soc/intel/alderlake
register "device_count" = "6"
# DDIA for eDP
register "device[0].name" = ""LCD""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0