GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/{t60,x201,x60}/smihandler: Remove SMM reinitialization 

Remove SMM reinitialization since it's already done in src/ec/lenovo/h8.
Untested on a real hardware.

See also commit 8953d4a1 with Change-Id
I33fd829a7e34aefa8f76ca6020cc8e802f7aab17 ("mb/lenovo/*/smihandler: Get
rid of mainboard_io_trap_handler").

Change-Id: Icc582527db15f3a31cdee8948bc5a190240fdc84
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36235
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Peter Lemenkov 2019-10-22 18:32:31 +02:00 committed by Patrick Georgi
parent b2832e3586
commit cfc93cbb66
3 changed files with 0 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/mainboard/lenovo/t60/smihandler.c
View File

@ -28,13 +28,6 @@
#define LVTMA_BL_MOD_LEVEL 0x7af9 /* ATI Radeon backlight level */ #define LVTMA_BL_MOD_LEVEL 0x7af9 /* ATI Radeon backlight level */
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
/* Enable 0x1600/0x1600 register pair */
ec_set_bit(0x00, 0x05);
}
static void mainboard_smi_brightness_down(void) static void mainboard_smi_brightness_down(void)
{ {
u8 *bar; u8 *bar;
@ -59,13 +52,6 @@ static void mainboard_smi_brightness_up(void)
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
switch (smif) { switch (smif) {
case SMI_DOCK_CONNECT: case SMI_DOCK_CONNECT:
/* If there's an legacy I/O module present, we're not /* If there's an legacy I/O module present, we're not

14
src/mainboard/lenovo/x201/smihandler.c
View File

@ -29,22 +29,8 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
/* Enable 0x1600/0x1600 register pair */
ec_set_bit(0x00, 0x05);
}
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
switch (smif) { switch (smif) {
case SMI_DOCK_CONNECT: case SMI_DOCK_CONNECT:
ec_clr_bit(0x03, 2); ec_clr_bit(0x03, 2);

14
src/mainboard/lenovo/x60/smihandler.c
View File

@ -29,13 +29,6 @@
#define GPE_EC_SCI 12 #define GPE_EC_SCI 12
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
/* Enable 0x1600/0x1600 register pair */
ec_set_bit(0x00, 0x05);
}
static void mainboard_smi_save_cmos(void) static void mainboard_smi_save_cmos(void)
{ {
u8 val; u8 val;
@ -55,13 +48,6 @@ static void mainboard_smi_save_cmos(void)
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
switch (smif) { switch (smif) {
case SMI_DOCK_CONNECT: case SMI_DOCK_CONNECT:
ec_clr_bit(0x03, 2); ec_clr_bit(0x03, 2);