Major cleanups of the hard_reset() code and config in coreboot.

- Drop unused "#object reset.o" entries.

 - Use CONFIG_HAVE_HARD_RESET for all "object reset.o" entries.

 - Drop dead/commented code, i.e. useless hard_reset() from:
   - supermicro/x6dhe_g/auto.c
   - supermicro/x6dhe_g2/auto.c
   - supermicro/x6dhe_g2/auto.updated.c
   - supermicro/x6dhr_ig/auto.c
   - supermicro/x6dhr_ig2/auto.c
   - digitallogic/msm586seg/auto.c
   - dell/s1850/auto.c

 - Add "obj-$(CONFIG_HAVE_HARD_RESET) += reset.o" to kconfig files of boards
   that actually have a reset.c file.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watson <mylesgw@gmail.com>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4849 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/mainboard/Makefile.romccboard.inc

@@ -45,6 +45,7 @@ driver-y += mainboard.o
 
 obj-$(CONFIG_GENERATE_MP_TABLE) += mptable.o
 obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 
 ifdef POST_EVALUATION
 

src/mainboard/amd/dbm690t/Config.lb

@@ -50,8 +50,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/amd/norwich/Config.lb

@@ -18,8 +18,6 @@ if CONFIG_GENERATE_PIRQ_TABLE
 	object irq_tables.o
 end
 
-#object reset.o
-
 	#compile cache_as_ram.c to auto.inc
 	makerule ./cache_as_ram_auto.inc
 			depends "$(CONFIG_MAINBOARD)/cache_as_ram_auto.c option_table.h"

src/mainboard/amd/pistachio/Config.lb

@@ -50,8 +50,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/amd/rumba/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/artecgroup/dbe61/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	#compile cache_as_ram.c to auto.inc
 	makerule ./cache_as_ram_auto.inc

src/mainboard/asus/a8v-e_se/Config.lb

@@ -39,7 +39,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 end
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 
   if CONFIG_USE_INIT
     makerule ./cache_as_ram_auto.o

src/mainboard/asus/mew-vm/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/broadcom/blast/Config.lb

@@ -18,8 +18,6 @@ if CONFIG_GENERATE_PIRQ_TABLE
 	object irq_tables.o 
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/dell/s1850/Config.lb

@@ -20,7 +20,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/dell/s1850/Makefile.inc

@@ -42,6 +42,7 @@ driver-y += mainboard.o
 
 obj-$(CONFIG_GENERATE_MP_TABLE) += mptable.o
 obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 
 ifdef POST_EVALUATION
 

src/mainboard/dell/s1850/auto.c

@@ -42,16 +42,6 @@
 #define RECVENA_CONFIG  0x0808090a
 #define RECVENB_CONFIG  0x0808090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/digitallogic/adl855pc/Config.lb

@@ -14,7 +14,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/digitallogic/adl855pc/Kconfig

@@ -8,6 +8,7 @@ config BOARD_DIGITALLOGIC_ADL855PC
 	select HAVE_PIRQ_TABLE
 	select UDELAY_TSC
 	select BOARD_ROMSIZE_KB_1024
+	select HAVE_HARD_RESET
 
 config MAINBOARD_DIR
 	string

src/mainboard/digitallogic/adl855pc/auto.c

@@ -31,7 +31,6 @@
 
 #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
 
-
 static void hard_reset(void)
 {
         outb(0x0e, 0x0cf9);

src/mainboard/digitallogic/msm586seg/Config.lb

@@ -16,7 +16,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 
 ##
 ## Romcc output

src/mainboard/digitallogic/msm586seg/auto.c

@@ -50,10 +50,6 @@ struct mem_controller {
 	int i;
 };
 
-static void hard_reset(void)
-{
-}
-
 static void memreset_setup(void)
 {
 }

src/mainboard/eaglelion/5bcm/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/emulation/qemu-x86/Config.lb

@@ -35,7 +35,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 
 ## ALL dependencies for CONFIG_USE_DCACHE_RAM go here. 

src/mainboard/gigabyte/ga_2761gxdk/Config.lb

@@ -37,7 +37,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT
 		makerule ./cache_as_ram_auto.o

src/mainboard/gigabyte/m57sli/Config.lb

@@ -35,7 +35,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT	
 		makerule ./cache_as_ram_auto.o

src/mainboard/ibm/e325/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_USE_INIT
 

src/mainboard/ibm/e326/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_USE_INIT
 

src/mainboard/iei/juki-511p/Config.lb

@@ -32,7 +32,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/iei/nova4899r/Config.lb

@@ -16,7 +16,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/intel/eagleheights/Config.lb

@@ -57,7 +57,7 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 if CONFIG_USE_INIT
 

src/mainboard/intel/eagleheights/Makefile.inc

@@ -4,7 +4,7 @@ obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += dsdt.o
-obj-y += reset.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 
 # This is part of the conversion to init-obj and away from included code.
 

src/mainboard/intel/jarrell/Config.lb

@@ -20,7 +20,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/intel/jarrell/Makefile.inc

@@ -1,4 +1,4 @@
-obj-y += reset.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 ROMCCFLAGS := -mcpu=p4 -O2
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/intel/xe7501devkit/Config.lb

@@ -12,7 +12,7 @@ driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE 		object mptable.o 	 end
 if CONFIG_GENERATE_PIRQ_TABLE 		object irq_tables.o	 end
 if CONFIG_GENERATE_ACPI_TABLES 	object acpi_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/intel/xe7501devkit/Makefile.inc

@@ -1,4 +1,5 @@
 ROMCCFLAGS := -mcpu=p4 -O2
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/iwill/dk8s2/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ## ATI Rage XL framebuffering graphics driver
 dir /drivers/ati/ragexl

src/mainboard/iwill/dk8x/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_USE_INIT
 

src/mainboard/kontron/986lcd-m/Config.lb

@@ -61,7 +61,7 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 if CONFIG_USE_INIT
 

src/mainboard/kontron/986lcd-m/Makefile.inc

@@ -32,6 +32,7 @@ obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += dsdt.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.o
 obj-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 
 smmobj-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.o
 

src/mainboard/kontron/kt690/Config.lb

@@ -50,8 +50,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/lippert/frontrunner/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/msi/ms6178/Config.lb

@@ -25,7 +25,6 @@ include /config/nofailovercalculation.lb
 arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 makerule ./failover.E
 	depends "$(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c ../romcc"
 	action "../romcc -E -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"

src/mainboard/msi/ms7260/Config.lb

@@ -28,7 +28,6 @@ driver mainboard.o
 object get_bus_conf.o # Needed by irq_tables and mptable (and acpi_tables).
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 
   if CONFIG_USE_INIT
     makerule ./cache_as_ram_auto.o

src/mainboard/msi/ms9282/Config.lb

@@ -43,7 +43,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_USE_INIT
 

src/mainboard/nec/powermate2000/Config.lb

@@ -25,7 +25,6 @@ include /config/nofailovercalculation.lb
 arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 makerule ./failover.E
 	depends "$(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c ../romcc"
 	action "../romcc -E -O2 -mcpu=p2 --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"

src/mainboard/newisys/khepri/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_USE_INIT
 

src/mainboard/nvidia/l1_2pvv/Config.lb

@@ -35,7 +35,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_GENERATE_ACPI_TABLES
 	object acpi_tables.o

src/mainboard/olpc/btest/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/olpc/rev_a/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 driver mainboard.o
 
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/rca/rm4100/Config.lb

@@ -25,7 +25,6 @@ include /config/nofailovercalculation.lb
 arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 if CONFIG_GENERATE_ACPI_TABLES
 	object fadt.o
 	object dsdt.o

src/mainboard/sunw/ultra40/Config.lb

@@ -16,7 +16,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 	if CONFIG_USE_INIT	
 		makerule ./auto.o
 		        depends "$(CONFIG_MAINBOARD)/cache_as_ram_auto.c option_table.h"

src/mainboard/supermicro/h8dme/Config.lb

@@ -32,7 +32,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT	
 		makerule ./auto.o

src/mainboard/supermicro/h8dmr/Config.lb

@@ -35,7 +35,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT	
 		makerule ./auto.o

src/mainboard/supermicro/h8dmr_fam10/Config.lb

@@ -37,7 +37,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT	
 		makerule ./auto.o

src/mainboard/supermicro/x6dai_g/Config.lb

@@ -20,7 +20,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/supermicro/x6dai_g/Makefile.inc

@@ -19,6 +19,6 @@
 ##
 
 ROMCCFLAGS=-mcpu=p4 -O2
-
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/supermicro/x6dhe_g/Config.lb

@@ -19,7 +19,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/supermicro/x6dhe_g/Makefile.inc

@@ -19,6 +19,6 @@
 ##
 
 ROMCCFLAGS=-mcpu=p4 -O2
-
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/supermicro/x6dhe_g/auto.c

@@ -43,16 +43,6 @@
 #define RECVENA_CONFIG  0x0808090a
 #define RECVENB_CONFIG  0x0808090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/supermicro/x6dhe_g2/Config.lb

@@ -19,7 +19,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/supermicro/x6dhe_g2/Makefile.inc

@@ -19,6 +19,6 @@
 ##
 
 ROMCCFLAGS=-mcpu=p4 -O2
-
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/supermicro/x6dhe_g2/auto.c

@@ -43,16 +43,6 @@
 #define RECVENA_CONFIG  0x0708090a
 #define RECVENB_CONFIG  0x0708090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/supermicro/x6dhe_g2/auto.updated.c

@@ -43,16 +43,6 @@
 #define RECVENA_CONFIG  0x0708090a
 #define RECVENB_CONFIG  0x0708090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/supermicro/x6dhr_ig/Config.lb

@@ -20,7 +20,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/supermicro/x6dhr_ig/Makefile.inc

@@ -19,6 +19,6 @@
 ##
 
 ROMCCFLAGS=-mcpu=p4 -O2
-
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/supermicro/x6dhr_ig/auto.c

@@ -44,16 +44,6 @@
 #define RECVENA_CONFIG  0x0808090a
 #define RECVENB_CONFIG  0x0808090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/supermicro/x6dhr_ig2/Config.lb

@@ -20,7 +20,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 
 ##
 ## Romcc output

src/mainboard/supermicro/x6dhr_ig2/Makefile.inc

@@ -19,6 +19,6 @@
 ##
 
 ROMCCFLAGS=-mcpu=p4 -O2
-
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 include $(src)/mainboard/Makefile.romccboard.inc
 

src/mainboard/supermicro/x6dhr_ig2/auto.c

@@ -44,16 +44,6 @@
 #define RECVENA_CONFIG  0x0808090a
 #define RECVENB_CONFIG  0x0808090a
 
-#if 0
-static void hard_reset(void)
-{
-	/* enable cf9 */
-	pci_write_config8(PCI_DEV(0, 0x04, 3), 0x41, 0xf1);
-	/* reset */
-	outb(0x0e, 0x0cf9);
-}
-#endif
-
 static inline void activate_spd_rom(const struct mem_controller *ctrl)
 {
 	/* nothing to do */

src/mainboard/technexion/tim5690/Config.lb

@@ -50,8 +50,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/technexion/tim8690/Config.lb

@@ -50,8 +50,6 @@ if CONFIG_GENERATE_ACPI_TABLES
 	object ./dsdt.o
 end
 
-#object reset.o
-
 	if CONFIG_USE_INIT
 
 		makerule ./cache_as_ram_auto.o

src/mainboard/technologic/ts5300/Config.lb

@@ -17,7 +17,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 
 ##
 ## Romcc output

src/mainboard/thomson/ip1000/Config.lb

@@ -25,7 +25,6 @@ include /config/nofailovercalculation.lb
 arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-# object reset.o
 if CONFIG_GENERATE_ACPI_TABLES
 	object fadt.o
 	object dsdt.o

src/mainboard/tyan/s2735/Config.lb

@@ -12,7 +12,7 @@ arch i386 end
 driver mainboard.o
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-object reset.o
+if CONFIG_HAVE_HARD_RESET object reset.o end
 if CONFIG_USE_INIT
 
 makerule ./auto.o

src/mainboard/tyan/s2735/Makefile.inc

@@ -27,6 +27,7 @@ driver-y +=  mainboard.o
 
 obj-$(CONFIG_GENERATE_MP_TABLE) += mptable.o
 obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o
+obj-$(CONFIG_HAVE_HARD_RESET) += reset.o
 
 #driver-y += ../../../drivers/i2c/i2cmux/i2cmux.o
 

src/mainboard/tyan/s2735/cache_as_ram_auto.c

@@ -37,6 +37,7 @@ static void post_code(uint8_t value) {
 
 #define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1)
 
+// FIXME: There's another hard_reset() in reset.c. Why?
 static void hard_reset(void)
 {
         /* full reset */

src/mainboard/tyan/s2735/reset.c

@@ -1,5 +1,6 @@
 void i82801er_hard_reset(void);
 
+/* FIXME: There's another hard_reset() in cache_as_ram_auto.c. Why? */
 void hard_reset(void)
 {
 	i82801er_hard_reset();

src/mainboard/tyan/s2891/Config.lb

@@ -18,7 +18,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_GENERATE_ACPI_TABLES
         object acpi_tables.o

src/mainboard/tyan/s2892/Config.lb

@@ -19,7 +19,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_GENERATE_ACPI_TABLES
         object acpi_tables.o

src/mainboard/tyan/s2895/Config.lb

@@ -14,7 +14,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 if CONFIG_GENERATE_ACPI_TABLES
         object acpi_tables.o

src/mainboard/tyan/s2912/Config.lb

@@ -35,7 +35,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT
 		makerule ./cache_as_ram_auto.o

src/mainboard/tyan/s2912_fam10/Config.lb

@@ -35,7 +35,6 @@ object get_bus_conf.o
 
 if CONFIG_GENERATE_MP_TABLE object mptable.o end
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 	if CONFIG_USE_INIT
 		makerule ./cache_as_ram_auto.o

src/mainboard/via/epia-m/Config.lb

@@ -15,7 +15,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 object vgabios.o
 
 if CONFIG_GENERATE_ACPI_TABLES

src/mainboard/via/epia/Config.lb

@@ -14,7 +14,6 @@ arch i386 end
 
 driver mainboard.o
 if CONFIG_GENERATE_PIRQ_TABLE object irq_tables.o end
-#object reset.o
 
 ##
 ## Romcc output

src/mainboard/via/vt8454c/reset.c

@@ -1,28 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-#include "arch/romcc_io.h"
-
-void hard_reset(void)
-{
-	set_bios_reset();
-	outb(0x06, 0x0cf9);
-}