From d1b8589583de2d34a3e8dcbe6b0f9e7522df7ca8 Mon Sep 17 00:00:00 2001 From: Ruihai Zhou Date: Thu, 27 Jul 2023 19:36:35 +0800 Subject: [PATCH] drivers/mipi: sta_ili9882t: Change TReset-CMD from 1.1 ms to 20 ms In the datasheet of ILI9882T [1] section 3.11 Power On/Off Sequence, the TReset-CMD (Reset to First Command in Display Sleep In Mode) should be larger than 10ms, but it's 1.1ms now. This may cause abnormal display as some commands may be lost during power on. Fix this and leave some margins by increasing TReset-CMD to 20ms. Also, to align with the kernel driver structure starry_ili9882t_init_cmd, add 20ms delay at the end of command. [1] ILI9882T_Datasheet_20220428.pdf BUG=b:293380212 TEST=Boot and display normally Signed-off-by: Ruihai Zhou Change-Id: Ifdcaf0e34753fc906817c763f1c8e7389448d1dc Reviewed-on: https://review.coreboot.org/c/coreboot/+/76766 Reviewed-by: cong yang Reviewed-by: Eric Lai Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/drivers/mipi/panel-STA_ILI9882T.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/drivers/mipi/panel-STA_ILI9882T.c b/src/drivers/mipi/panel-STA_ILI9882T.c index 51f01e5017..251464235d 100644 --- a/src/drivers/mipi/panel-STA_ILI9882T.c +++ b/src/drivers/mipi/panel-STA_ILI9882T.c @@ -19,6 +19,7 @@ struct panel_serializable_data STA_ILI9882T = { }, }, .init = { + PANEL_DELAY(20), PANEL_DCS(0xFF, 0x98, 0x82, 0x01), PANEL_DCS(0x00, 0x42), PANEL_DCS(0x01, 0x11), @@ -325,5 +326,6 @@ struct panel_serializable_data STA_ILI9882T = { PANEL_DCS(0x11), PANEL_DELAY(120), PANEL_DCS(0x29), + PANEL_DELAY(20), }, };