From d1eca65908464d1760db96b0aa3b2b3dbfcc4c4a Mon Sep 17 00:00:00 2001 From: Gergely Kiss Date: Thu, 18 Jan 2018 20:53:06 +0100 Subject: [PATCH] mainboard/asus/am1i-a: remove unwanted variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The variable t32 was originally used to do bitwise operations, but it is not required anymore. Also, it was assigned twice accidentally, which introduced a new Coverity Scan defect. Found-by: Coverity (CID 1385126: (UNUSED_VALUE)) Change-Id: I77afd5064304a36991f63cf1328e13820144efb6 Signed-off-by: Gergely Kiss Reviewed-on: https://review.coreboot.org/23320 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel --- src/mainboard/asus/am1i-a/romstage.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mainboard/asus/am1i-a/romstage.c b/src/mainboard/asus/am1i-a/romstage.c index d62052f08f..c7cd93e515 100644 --- a/src/mainboard/asus/am1i-a/romstage.c +++ b/src/mainboard/asus/am1i-a/romstage.c @@ -116,7 +116,7 @@ static void ite_gpio_conf(pnp_devfn_t dev) void board_BeforeAgesa(struct sysinfo *cb) { int i; - u32 t32, val; + u32 val; u8 byte; pci_devfn_t dev; u32 *addr32; @@ -145,15 +145,11 @@ void board_BeforeAgesa(struct sysinfo *cb) /* Configure ClkDrvStr1 settings */ addr32 = (u32 *)0xfed80e24; - t32 = *addr32; - t32 = 0x030800aa; - *addr32 = t32; + *addr32 = 0x030800aa; /* Configure MiscClkCntl1 settings */ addr32 = (u32 *)0xfed80e40; - t32 = *addr32; - t32 = 0x000c4050; - *addr32 = t32; + *addr32 = 0x000c4050; /* enable SIO LPC decode */ dev = PCI_DEV(0, 0x14, 3);