GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/via: Use DEVICE_NOOP macro over dummy symbol 

Change-Id: Ib9d0fae363c5c1fbed3a63cb8aa86716cf1f9ee1
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7289
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
This commit is contained in:
Edward O'Callaghan 2014-10-31 08:26:21 +11:00
parent 812d2a47d4
commit d2040737a9
14 changed files with 40 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/via/cn400/agp.c
View File

@ -128,7 +128,7 @@ static void agp_init(device_t dev)
}
static const struct device_operations agp_operations = {
.read_resources = cn400_noop,
.read_resources = DEVICE_NOOP,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = agp_init,

7
src/northbridge/via/cn400/cn400.h
View File

@ -18,13 +18,6 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#ifndef __PRE_RAM__
// HACK
static inline void cn400_noop(device_t dev)
{
}
#endif
#define DEBUG_CN400
/* VGA stuff */

18
src/northbridge/via/cn400/northbridge.c
View File

@ -127,10 +127,10 @@ static void memctrl_init(device_t dev)
}
static const struct device_operations memctrl_operations = {
.read_resources = cn400_noop,
.set_resources = cn400_noop,
.enable_resources = cn400_noop,
.init = memctrl_init,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = memctrl_init,
.ops_pci = 0,
};
@ -241,14 +241,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

18
src/northbridge/via/cn400/vlink.c
View File

@ -158,9 +158,9 @@ static void c3_host_init(device_t dev)
}
static const struct device_operations c3_host_operations = {
.read_resources = cn400_noop,
.set_resources = cn400_noop,
.enable_resources = cn400_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = c3_host_init,
.ops_pci = 0,
};
@ -195,9 +195,9 @@ static void c3_err_init(device_t dev)
}
static const struct device_operations c3_err_operations = {
.read_resources = cn400_noop,
.set_resources = cn400_noop,
.enable_resources = cn400_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = c3_err_init,
.ops_pci = 0,
};
@ -231,9 +231,9 @@ static void cn400_pm_init(device_t dev)
}
static const struct device_operations cn400_pm_operations = {
.read_resources = cn400_noop,
.set_resources = cn400_noop,
.enable_resources = cn400_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cn400_pm_init,
.ops_pci = 0,
};

4
src/northbridge/via/cn700/agp.c
View File

@ -104,7 +104,7 @@ static void agp_init(device_t dev)
}
static const struct device_operations agp_operations = {
.read_resources = cn700_noop,
.read_resources = DEVICE_NOOP,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = agp_init,
@ -157,7 +157,7 @@ static void agp_bridge_init(device_t dev)
}
static const struct device_operations agp_bridge_operations = {
.read_resources = cn700_noop,
.read_resources = DEVICE_NOOP,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_bus_enable_resources,
.init = agp_bridge_init,

7
src/northbridge/via/cn700/cn700.h
View File

@ -18,13 +18,6 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#if !defined (__PRE_RAM__)
// HACK
static inline void cn700_noop(device_t dev)
{
}
#endif
/* VGA stuff */
#define SR_INDEX 0x3c4
#define SR_DATA 0x3c5

12
src/northbridge/via/cn700/northbridge.c
View File

@ -87,7 +87,7 @@ static void memctrl_init(device_t dev)
}
static const struct device_operations memctrl_operations = {
.read_resources = cn700_noop,
.read_resources = DEVICE_NOOP,
.init = memctrl_init,
};
@ -161,14 +161,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

6
src/northbridge/via/cx700/agp.c
View File

@ -72,12 +72,8 @@ static void agp_bridge_init(device_t dev)
pci_write_config8(dev, 0x44, 0x34);
}
static void cx700_noop(device_t dev)
{
}
static struct device_operations agp_bridge_operations = {
.read_resources = cx700_noop,
.read_resources = DEVICE_NOOP,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_bus_enable_resources,
.init = agp_bridge_init,

10
src/northbridge/via/cx700/northbridge.c
View File

@ -117,14 +117,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

10
src/northbridge/via/vt8601/northbridge.c
View File

@ -107,14 +107,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

10
src/northbridge/via/vt8623/northbridge.c
View File

@ -167,14 +167,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

12
src/northbridge/via/vx800/northbridge.c
View File

@ -61,7 +61,7 @@ static void memctrl_init(device_t dev)
}
static const struct device_operations memctrl_operations = {
.read_resources = vx800_noop,
.read_resources = DEVICE_NOOP,
.init = memctrl_init,
};
@ -150,14 +150,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};

7
src/northbridge/via/vx800/vx800.h
View File

@ -20,13 +20,6 @@
#ifndef VX800_H
#define VX800_H 1
#ifndef __PRE_RAM__
#include <device/device.h>
static inline void vx800_noop(device_t dev)
{
}
#endif
#ifdef __PRE_RAM__
/* vx800_early_smbus.c */
struct mem_controller;

10
src/northbridge/via/vx900/northbridge.c
View File

@ -322,14 +322,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list);
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};